Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754325AbbBZTF3 (ORCPT ); Thu, 26 Feb 2015 14:05:29 -0500 Received: from mail-lb0-f180.google.com ([209.85.217.180]:39714 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754141AbbBZTF1 (ORCPT ); Thu, 26 Feb 2015 14:05:27 -0500 MIME-Version: 1.0 In-Reply-To: References: <424678035-12862-1-git-send-email-srinivas.kandagatla@linaro.org> <1424678093-12966-1-git-send-email-srinivas.kandagatla@linaro.org> Date: Thu, 26 Feb 2015 11:05:25 -0800 Message-ID: Subject: Re: [PATCH 01/12] ARM: dts: apq8064: add RPM regulators support From: Bjorn Andersson To: Kumar Gala Cc: Srinivas Kandagatla , linux-arm-msm , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 25 On Thu, Feb 26, 2015 at 10:25 AM, Kumar Gala wrote: > > On Feb 23, 2015, at 1:54 AM, Srinivas Kandagatla wrote: > >> This patch adds rpm node to apq8064 dt as rpm would be used by other >> devices for regulator support. Also adds all the regulators in the rpm. >> >> Signed-off-by: Srinivas Kandagatla [..] >> + interrupts = <0 19 0>, <0 21 0>, <0 22 0>; >> + interrupt-names = "ack", "err", "wakeup"; >> + > > Can you use the defines for GIC for the interrupts. Also, I think the last property should probably be level high instead of 0. > The code sets it to rising, but better move that to the dt (as you suggest). Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/