Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932277AbbBZUUs (ORCPT ); Thu, 26 Feb 2015 15:20:48 -0500 Received: from mail-wg0-f53.google.com ([74.125.82.53]:34046 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753643AbbBZUUr (ORCPT ); Thu, 26 Feb 2015 15:20:47 -0500 Message-ID: <54EF801B.4080201@linaro.org> Date: Thu, 26 Feb 2015 20:20:43 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bjorn Andersson CC: Kumar Gala , linux-arm-msm , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 01/12] ARM: dts: apq8064: add RPM regulators support References: <424678035-12862-1-git-send-email-srinivas.kandagatla@linaro.org> <1424678093-12966-1-git-send-email-srinivas.kandagatla@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1581 Lines: 45 On 26/02/15 19:00, Bjorn Andersson wrote: > On Sun, Feb 22, 2015 at 11:54 PM, Srinivas Kandagatla > wrote: >> This patch adds rpm node to apq8064 dt as rpm would be used by other >> devices for regulator support. Also adds all the regulators in the rpm. >> > > This looks good, with Kumars suggestion of GIT defines > Reviewed-by: Bjorn Andersson > Thanks Bjorn for Review. > However, this binding is not merged yet and Stephen have requesting a > complete redesign of the binding as well as the code. So that has to > be concluded first, I presume. > Hmm, I know, It does not make sense to keep these patches locally waiting for something to change in future, Am not sure when those new changes be actually merged into the mainline? IMHO, we should merge this patches as they are perfectly applicable to whats on linus-tree. And fix if required when the new design is accepted. > > Separate of that, as it's highly likely that everyone will follow the > pcb design guidelines for apq8064 the vin-supplies should be okay to > specify at this level (and not in all board files). Perhaps also the > switching frequencies for the SMPSs? I will investigate on this and see If I can add some more useful contents to the nodes. Thanks, srini > > Regards, > Bjorn > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/