Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754064AbbBZU3t (ORCPT ); Thu, 26 Feb 2015 15:29:49 -0500 Received: from canardo.mork.no ([148.122.252.1]:34418 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753539AbbBZU3s convert rfc822-to-8bit (ORCPT ); Thu, 26 Feb 2015 15:29:48 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Imre Deak , linux-kernel@vger.kernel.org, Daniel Vetter , Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: fix failure to power off after hibernate Organization: m References: <87bnkjcqjt.fsf@nemi.mork.no> <1424789904-26699-1-git-send-email-bjorn@mork.no> <1424794340.15554.3.camel@intel.com> <878ufnjfrr.fsf@nemi.mork.no> <1424889214.5991.4.camel@intel.com> <87bnkhqan8.fsf@nemi.mork.no> <1424976648.17078.1.camel@intel.com> <20150226200556.GF11371@intel.com> Date: Thu, 26 Feb 2015 21:29:31 +0100 In-Reply-To: <20150226200556.GF11371@intel.com> ("Ville =?utf-8?B?U3lyasOk?= =?utf-8?B?bMOkIidz?= message of "Thu, 26 Feb 2015 22:05:56 +0200") Message-ID: <87pp8w2z84.fsf@nemi.mork.no> User-Agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.3.9 (canardo.mork.no [IPv6:2001:4641::1]); Thu, 26 Feb 2015 21:29:33 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 34 Ville Syrjälä writes: >> @@ -651,7 +651,14 @@ static int i915_drm_suspend_late(struct drm_device *drm_dev) >> } >> >> pci_disable_device(drm_dev->pdev); >> - pci_set_power_state(drm_dev->pdev, PCI_D3hot); >> + /* >> + * During hibernation on some GM45 platforms the BIOS may try to access >> + * the device even though it's already in D3 and hang the machine. So >> + * leave the device in D0 on those platforms and hope the BIOS will >> + * power down the device properly. > > Please include the model of the known bad machine in this comment, to > help future archaeologists. Here are some details: bjorn@nemi:~$ grep . /sys/class/dmi/id/{bios,product}* 2>/dev/null /sys/class/dmi/id/bios_date:12/19/2011 /sys/class/dmi/id/bios_vendor:LENOVO /sys/class/dmi/id/bios_version:6EET55WW (3.15 ) /sys/class/dmi/id/product_name:2776LEG /sys/class/dmi/id/product_version:ThinkPad X301 Please let me know if you need some other data. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/