Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754491AbbBZUxB (ORCPT ); Thu, 26 Feb 2015 15:53:01 -0500 Received: from mail.kernel.org ([198.145.29.136]:59954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754297AbbBZUw7 (ORCPT ); Thu, 26 Feb 2015 15:52:59 -0500 Message-ID: <54EF87A4.6090609@kernel.org> Date: Fri, 27 Feb 2015 05:52:52 +0900 From: Kukjin Kim User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.16 MIME-Version: 1.0 To: Stephen Boyd CC: Krzysztof Kozlowski , Russell King , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park , Marek Szyprowski , stable@vger.kernel.org Subject: Re: [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency References: <1424093802-5488-1-git-send-email-k.kozlowski@samsung.com> <54E3BFB3.5030801@codeaurora.org> In-Reply-To: <54E3BFB3.5030801@codeaurora.org> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 27 On 02/18/15 07:24, Stephen Boyd wrote: > On 02/16/15 05:36, Krzysztof Kozlowski wrote: >> During CPU shutdown the exynos_cpu_power_down() is called after >> disabling cache coherency and it uses LDREX and STREX instructions (by >> calling of_machine_is_compatible() -> kobject_get() -> kref_get()). >> >> The LDREX and STREX should not be used after disabling the cache >> coherency so just use soc_is_exynos(). >> >> Signed-off-by: Krzysztof Kozlowski >> Fixes: adc548d77c22 ("ARM: EXYNOS: Use MCPM call-backs to support S2R on exynos5420") >> Cc: >> Reported-by: Stephen Boyd >> --- > > Looks good to me. > > Reviewed-by: Stephen Boyd > Thanks for this fix, applied. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/