Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754426AbbBZVUX (ORCPT ); Thu, 26 Feb 2015 16:20:23 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:35496 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754345AbbBZVUS (ORCPT ); Thu, 26 Feb 2015 16:20:18 -0500 MIME-Version: 1.0 In-Reply-To: <54EF7DFD.9020609@codeaurora.org> References: <424678035-12862-1-git-send-email-srinivas.kandagatla@linaro.org> <1424678093-12966-1-git-send-email-srinivas.kandagatla@linaro.org> <54EF748B.3090404@codeaurora.org> <54EF7D74.7060906@linaro.org> <54EF7DFD.9020609@codeaurora.org> Date: Thu, 26 Feb 2015 13:20:17 -0800 Message-ID: Subject: Re: [PATCH 01/12] ARM: dts: apq8064: add RPM regulators support From: Bjorn Andersson To: Stephen Boyd Cc: Srinivas Kandagatla , Kumar Gala , linux-arm-msm , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1419 Lines: 39 On Thu, Feb 26, 2015 at 12:11 PM, Stephen Boyd wrote: > On 02/26/15 12:09, Srinivas Kandagatla wrote: >> >> >> On 26/02/15 19:31, Stephen Boyd wrote: >>> On 02/22/15 23:54, Srinivas Kandagatla wrote: >>>> + pm8921_s5: pm8921-s5 { >>>> + compatible = "qcom,rpm-pm8921-ftsmps"; >>>> + reg = ; >>>> + }; >>>> + >>>> + pm8921_s6: pm8921-s6 { >>>> + compatible = "qcom,rpm-pm8921-ftsmps"; >>>> + reg = ; >>>> + }; >>>> + >>> >>> There's no RPM control for S5 and S6. Please remove. Also, has this been >>> tested? >>> >> Ahh. these are SAW regulators, I will remove it from the list. >> Obviously, I did not test all the regulators. > > There are some more that don't seem to match what we have downstream. > L26 is also SAW related, and the usb and hdmi switches are "locally" > controlled via ssbi pmic writes. > According to msm-3.4 all three are controlled by pm8xxx-regulator, but they are also exposed through the RPM - which I think I tested (a year ago or so). Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/