Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932240AbbBZWZS (ORCPT ); Thu, 26 Feb 2015 17:25:18 -0500 Received: from mail-we0-f176.google.com ([74.125.82.176]:46497 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbbBZWZP (ORCPT ); Thu, 26 Feb 2015 17:25:15 -0500 MIME-Version: 1.0 In-Reply-To: <1424907152-18808-1-git-send-email-mathieu.poirier@linaro.org> References: <1424907152-18808-1-git-send-email-mathieu.poirier@linaro.org> From: Rob Herring Date: Thu, 26 Feb 2015 16:24:53 -0600 Message-ID: Subject: Re: [PATCH v2] coresight-stm: adding driver for CoreSight STM component To: Mathieu Poirier , Will Deacon Cc: "linux-api@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jonathan Corbet Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 44 Adding Will D... On Wed, Feb 25, 2015 at 5:32 PM, Mathieu Poirier wrote: > From: Pratik Patel > > This driver adds support for the STM CoreSight IP block, > allowing any system compoment (HW or SW) to log and > aggregate messages via a single entity. > > The STM exposes an application defined number of channels > called stimulus port. Configuration is done using entries > in sysfs and channels made available to userspace via devfs. > > Signed-off-by: Pratik Patel > Signed-off-by: Mathieu Poirier > --- > Changes for v2: > - Fixed typo in struct stm_node documentation > - Added CPU_32v3 to list of architecture STM can't work with Is this because of no strd instr only? > +#ifndef CONFIG_64BIT > +static inline void __raw_writeq(u64 val, volatile void __iomem *addr) > +{ > + asm volatile("strd %1, %0" > + : "+Qo" (*(volatile u64 __force *)addr) > + : "r" (val)); > +} > +#undef writeq_relaxed > +#define writeq_relaxed(v, c) __raw_writeq((__force u64) cpu_to_le64(v), c) > +#endif We really shouldn't do private implementation here. It there really any reason not to allow readq/writeq generically for 32-bit or just for arm32? Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/