Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932445AbbBZXEA (ORCPT ); Thu, 26 Feb 2015 18:04:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59985 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932246AbbBZXD7 (ORCPT ); Thu, 26 Feb 2015 18:03:59 -0500 Date: Thu, 26 Feb 2015 15:03:57 -0800 From: Andrew Morton To: Ingo Molnar , Hector Marco Gisbert , Kees Cook , LKML , ismael Ripoll , "x86@kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux MIPS Mailing List , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] Fix offset2lib issue for x86*, ARM*, PowerPC and MIPS Message-Id: <20150226150357.b9343de08c96cb366d7e1d56@linux-foundation.org> In-Reply-To: <20150226143815.09386fe280c7bd8797048bb2@linux-foundation.org> References: <54EB735F.5030207@upv.es> <20150223205436.15133mg1kpyojyik@webmail.upv.es> <20150224073906.GA16422@gmail.com> <20150226143815.09386fe280c7bd8797048bb2@linux-foundation.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 927 Lines: 29 On Thu, 26 Feb 2015 14:38:15 -0800 Andrew Morton wrote: > Does that __weak trick even work? Nope. --- a/fs/binfmt_elf.c~fix-offset2lib-issue-for-x86-arm-powerpc-and-mips-fix-fix +++ a/fs/binfmt_elf.c @@ -2307,10 +2307,10 @@ unsigned long __weak mmap_rnd(void) } /* - * Not all architectures use randomize_et_dyn(), so use __weak to let the - * linker omit it from vmlinux + * Not all architectures use randomize_et_dyn(), but there doesn't seem to be + * a compile-time way of avoiding its generation. */ -unsigned long __weak randomize_et_dyn(unsigned long base) +unsigned long randomize_et_dyn(unsigned long base) { unsigned long ret; _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/