Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524AbbB0Aa3 (ORCPT ); Thu, 26 Feb 2015 19:30:29 -0500 Received: from mga14.intel.com ([192.55.52.115]:60063 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753882AbbB0AaX (ORCPT ); Thu, 26 Feb 2015 19:30:23 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,656,1418112000"; d="scan'208";a="684115592" From: "Zheng, Lv" To: "Rafael J. Wysocki" , Scot Doyle CC: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ACPI / EC: Remove non-standard log emphasis Thread-Topic: [PATCH] ACPI / EC: Remove non-standard log emphasis Thread-Index: AQHQSz+IJR5vaRf3sEKJVgdSifHzxp0BFOrwgAADh8D//+K4AIAAhKOAgAIyixA= Date: Fri, 27 Feb 2015 00:30:17 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E88026D82CE@SHSMSX101.ccr.corp.intel.com> References: <1AE640813FDE7649BE1B193DEA596E88026D8057@SHSMSX101.ccr.corp.intel.com> <3416235.WAfNBEHG25@vostro.rjw.lan> In-Reply-To: <3416235.WAfNBEHG25@vostro.rjw.lan> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t1R0UXBZ006188 Content-Length: 1700 Lines: 48 Hi, > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Thursday, February 26, 2015 6:56 AM > > On Wednesday, February 25, 2015 03:01:08 PM Scot Doyle wrote: > > On Wed, 25 Feb 2015, Zheng, Lv wrote: > > ... > > > > I was using "+++++"/"#####"/"*****" to filter different EC log entries which makes debugging easier. > > > > And, if we changed this from pr_info into pr_debug, then we will have nothing in the suspend/resume logs for the EC device. > > > > While there are plenty of such log entries for each of other devices. > > > > So I really doubt what's the meaning of such a change. > > > > Could it improve anything or just make debugging more difficult for developers? > > > > > > IMO, it's better to introduce such kind of code in the head of ec.c: > > > > > > #ifdef DEBUG_FILTER > > > #define EC_LOG_DEV "+++++" > > > #define EC_LOG_CMD "*****" > > > #define EC_LOG_EVT "#####" > > > ... > > > #else > > > #define EC_LOG_DEV > > > #define EC_LOG_CMD > > > #define EC_LOG_EVT > > > #endif > > > > > > And wrap the pr_info, pr_debug using filter enabled new macros - ec_info, ec_debug so that we won't see the filters in the > normal dmesg output and the filters are still available for the developers. > > > > > > Thanks and best regards > > > -Lv > > > > I agree, would you be willing to submit it? > > Yes, sounds good to me too! OK. Let me try it and send the revised one after testing. Thanks and best regards -Lv > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?