Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754255AbbB0CZh (ORCPT ); Thu, 26 Feb 2015 21:25:37 -0500 Received: from ispman.iskranet.ru ([62.213.33.10]:39189 "EHLO ispman.iskranet.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753244AbbB0CZg (ORCPT ); Thu, 26 Feb 2015 21:25:36 -0500 From: Arseny Solokha To: Benjamin Herrenschmidt Cc: Paul Mackerras , Michael Ellerman , Scott Wood , , , Subject: Re: [PATCH 4/4] powerpc/mpic: remove unused functions References: <1424084188-17097-1-git-send-email-asolokha@kb.kras.ru> <1424768706-23150-1-git-send-email-asolokha@kb.kras.ru> <1424768706-23150-5-git-send-email-asolokha@kb.kras.ru> Date: Fri, 27 Feb 2015 09:25:28 +0700 In-Reply-To: <1424768706-23150-5-git-send-email-asolokha@kb.kras.ru> (Arseny Solokha's message of "Tue, 24 Feb 2015 16:05:06 +0700") Message-ID: <87zj80jdk7.fsf@KB00016249.iskra.kb> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1516 Lines: 44 > @@ -1676,31 +1666,6 @@ void __init mpic_init(struct mpic *mpic) > mpic_err_int_init(mpic, MPIC_FSL_ERR_INT); > } > > -void __init mpic_set_clk_ratio(struct mpic *mpic, u32 clock_ratio) > -{ > - u32 v; > - > - v = mpic_read(mpic->gregs, MPIC_GREG_GLOBAL_CONF_1); > - v &= ~MPIC_GREG_GLOBAL_CONF_1_CLK_RATIO_MASK; > - v |= MPIC_GREG_GLOBAL_CONF_1_CLK_RATIO(clock_ratio); > - mpic_write(mpic->gregs, MPIC_GREG_GLOBAL_CONF_1, v); > -} > - > -void __init mpic_set_serial_int(struct mpic *mpic, int enable) > -{ > - unsigned long flags; > - u32 v; > - > - raw_spin_lock_irqsave(&mpic_lock, flags); > - v = mpic_read(mpic->gregs, MPIC_GREG_GLOBAL_CONF_1); > - if (enable) > - v |= MPIC_GREG_GLOBAL_CONF_1_SIE; > - else > - v &= ~MPIC_GREG_GLOBAL_CONF_1_SIE; > - mpic_write(mpic->gregs, MPIC_GREG_GLOBAL_CONF_1, v); > - raw_spin_unlock_irqrestore(&mpic_lock, flags); > -} > - > void mpic_irq_set_priority(unsigned int irq, unsigned int pri) > { > struct mpic *mpic = mpic_find(irq); Thinking about it some more, I wonder whether it makes sense to propagate these values through device tree (and refuse to apply them if they are 0), just like what timer_group_get_freq() and timer_group_get_irq() in arch/powerpc/sysdev/mpic_timer.c do. Does it have any real use? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/