Date: Fri, 27 Feb 2015 18:03:45 +0900
From: Gyungoh Yoo <gyungoh@gmail.com>
To: Oliver Neukum <oneukum@suse.de>
Cc: sameo@linux.intel.com, lee.jones@linaro.org, robh+dt@kernel.org,
        jg1.han@samsung.com, pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
        trivial@kernel.org, broonie@kernel.org, florian.vaussard@epfl.ch,
        andrew@lunn.ch, antonynpavlov@gmail.com, hytszk@gmail.com,
        plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, jack.yoo@skyworksinc.com,
        linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, treding@nvidia.com, p.zabel@pengutronix.de,
        arno@natisbad.org, kuninori.morimoto.gx@renesas.com
Subject: Re: [PATCH v11 2/6] backlight: Add support Skyworks SKY81452
 backlight driver
Message-ID: <20150227090345.GA4891@jack-ThinkPad-T520>
References: <1425019346-4559-1-git-send-email-jack.yoo@skyworksinc.com>
 <1425019346-4559-3-git-send-email-jack.yoo@skyworksinc.com>
 <1425027518.12236.5.camel@linux-0dmf.site>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1425027518.12236.5.camel@linux-0dmf.site>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1164
Lines: 38

On Fri, Feb 27, 2015 at 09:58:38AM +0100, Oliver Neukum wrote:
> On Fri, 2015-02-27 at 15:42 +0900, gyungoh@gmail.com wrote:
> > +static ssize_t sky81452_bl_store_enable(struct device *dev,
> > +               struct device_attribute *attr, const char *buf, size_t
> > count)
> > +{
> > +       struct regmap *regmap = bl_get_data(to_backlight_device(dev));
> > +       unsigned long value;
> > +       int ret;
> > +
> > +       ret = kstrtoul(buf, 16, &value);
> > +       if (IS_ERR_VALUE(ret))
> > +               return ret;
> 
> No range checking?

It doesn't need it. below regmap_update_bits() is masking the value.

> 
> > +
> > +       ret = regmap_update_bits(regmap, SKY81452_REG1, SKY81452_EN,
> > +                                       value << CTZ(SKY81452_EN));
> > +       if (IS_ERR_VALUE(ret))
> > +               return ret;
> > +
> > +       return count;
> > +}
> 
> 	Regards
> 		Oliver
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/