Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbbB0J14 (ORCPT ); Fri, 27 Feb 2015 04:27:56 -0500 Received: from mail-we0-f169.google.com ([74.125.82.169]:40035 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbbB0J1y (ORCPT ); Fri, 27 Feb 2015 04:27:54 -0500 MIME-Version: 1.0 In-Reply-To: <20150226133329.8a80c302d3ec014a2b0d58ff@linux-foundation.org> References: <20150223103810.GA16869@devel.8.8.4.4> <20150226133329.8a80c302d3ec014a2b0d58ff@linux-foundation.org> Date: Fri, 27 Feb 2015 18:27:53 +0900 Message-ID: Subject: Re: [PATCH 1/3] ocfs2: remove unneeded variable 'status' From: DaeSeok Youn To: Andrew Morton Cc: mfasheh@suse.com, Joel Becker , ocfs2-devel@oss.oracle.com, linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 989 Lines: 31 Hi, I think this patch was already queued. Can I send this patch again after update changelog? Thanks. Regards, Daeseok Youn 2015-02-27 6:33 GMT+09:00 Andrew Morton : > On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn wrote: > >> Use 'retval' instead of 'status'. >> > > The patch does a lot more than this. It causes __ocfs2_add_entry to > propagate error codes which were previously dropped on the floor. > > Please update the changelog to fully explain the functional changes and > to explain why they are desirable. > > After the patch there is still one unchecked call to > ocfs2_journal_access_di() and one unchecked call to > ocfs2_journal_access_db(). Probably these are bugs. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/