Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752826AbbB0J7U (ORCPT ); Fri, 27 Feb 2015 04:59:20 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:24194 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbbB0J7Q (ORCPT ); Fri, 27 Feb 2015 04:59:16 -0500 Message-ID: <54F03FD4.9030200@huawei.com> Date: Fri, 27 Feb 2015 17:58:44 +0800 From: He Kuang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: , , , CC: , Subject: Re: [PATCH] perf report: Fix branch stack mode cannot be set References: <1423967617-28879-1-git-send-email-hekuang@huawei.com> In-Reply-To: <1423967617-28879-1-git-send-email-hekuang@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.110.54.65] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2425 Lines: 52 ping.. ?? 2015/2/15 10:33, He Kuang ะด??: > When perf.data file be abtained by using 'perf record -b', perf report > should use branch stack mode to generate output. But this function is > broken by improper comparison between boolean and constant -1. > > before this patch: > $perf report -b -i perf.data > Samples: 16 of event 'cycles', Event count (approx.): 3171896 > Overhead Command Shared Object Symbol > 13.59% ls [kernel.kallsyms] [k] prio_tree_remove > 13.16% ls [kernel.kallsyms] [k] change_pte_range > 12.09% ls [kernel.kallsyms] [k] page_fault > 12.02% ls [kernel.kallsyms] [k] zap_pte_range > ... > > after this patch: > $perf report -b -i perf.data > Samples: 256 of event 'cycles', Event count (approx.): 256 > Overhead Command Source Shared Object Source Symbol Target Shared Object Target Symbol > 9.38% ls [unknown] [k] 0000000000000000 [unknown] [k] 0000000000000000 > 6.25% ls libc-2.19.so [.] _dl_addr libc-2.19.so [.] _dl_addr > 6.25% ls [kernel.kallsyms] [k] zap_pte_range [kernel.kallsyms] [k] zap_pte_range > 6.25% ls [kernel.kallsyms] [k] change_pte_range [kernel.kallsyms] [k] change_pte_range > 0.39% ls [kernel.kallsyms] [k] prio_tree_remove [kernel.kallsyms] [k] prio_tree_remove > ... > > Signed-off-by: He Kuang > --- > tools/perf/builtin-report.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > index 2f91094..ecc453b 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -766,7 +766,7 @@ repeat: > * 0/1 means the user chose a mode. > */ > if (((branch_mode == -1 && has_br_stack) || branch_mode == 1) && > - branch_call_mode == -1) { > + !branch_call_mode) { > sort__mode = SORT_MODE__BRANCH; > symbol_conf.cumulate_callchain = false; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/