Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754005AbbB0MOi (ORCPT ); Fri, 27 Feb 2015 07:14:38 -0500 Received: from osiris.lip6.fr ([132.227.60.30]:57973 "EHLO osiris.lip6.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbbB0MOh (ORCPT ); Fri, 27 Feb 2015 07:14:37 -0500 X-pt: osiris.lip6.fr From: Valentin Rothberg To: ralf@linux-mips.org, taohl@lemote.com, chenhc@lemote.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Cc: Valentin Rothberg Subject: [PATCH] loongson-3/hpet.c: remove IRQF_DISABLED flag Date: Fri, 27 Feb 2015 13:14:22 +0100 Message-Id: <1425039262-20003-1-git-send-email-Valentin.Rothberg@lip6.fr> X-Mailer: git-send-email 1.9.1 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (osiris.lip6.fr [132.227.60.30]); Fri, 27 Feb 2015 13:14:28 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1152 Lines: 31 The IRQF_DISABLED is a NOOP and scheduled to be removed. According to Ingo Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ handlers with interrupts enabled can cause stack overflows when the interrupt line of the issuing device is still active. Signed-off-by: Valentin Rothberg --- arch/mips/loongson/loongson-3/hpet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/loongson/loongson-3/hpet.c b/arch/mips/loongson/loongson-3/hpet.c index e898d68..5c21cd3 100644 --- a/arch/mips/loongson/loongson-3/hpet.c +++ b/arch/mips/loongson/loongson-3/hpet.c @@ -162,7 +162,7 @@ static irqreturn_t hpet_irq_handler(int irq, void *data) static struct irqaction hpet_irq = { .handler = hpet_irq_handler, - .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER, + .flags = IRQF_NOBALANCING | IRQF_TIMER, .name = "hpet", }; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/