Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753408AbbB0MWw (ORCPT ); Fri, 27 Feb 2015 07:22:52 -0500 Received: from mail-we0-f179.google.com ([74.125.82.179]:43393 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752291AbbB0MWt convert rfc822-to-8bit (ORCPT ); Fri, 27 Feb 2015 07:22:49 -0500 From: Michal Nazarewicz To: Tal Shorer , linux-usb@vger.kernel.org Cc: balbi@ti.com, gregkh@linuxfoundation.org, tal.shorer@gmail.com, andrzej.p@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value In-Reply-To: <1424976170-2361-1-git-send-email-tal.shorer@gmail.com> Organization: http://mina86.com/ References: <1424976170-2361-1-git-send-email-tal.shorer@gmail.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.0.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:150227:andrzej.p@samsung.com::ClRBYYcWrarTzK1X:000000000000000000000000000000000000000006GD X-Hashcash: 1:20:150227:tal.shorer@gmail.com::ySBGnuVlybyW4g6M:000000000000000000000000000000000000000000WgG X-Hashcash: 1:20:150227:balbi@ti.com::8UmagkLNZKctVgNt:000000DVh X-Hashcash: 1:20:150227:linux-usb@vger.kernel.org::7kd2VqlOdDWs8MDZ:0000000000000000000000000000000000005CcD X-Hashcash: 1:20:150227:linux-kernel@vger.kernel.org::6TuhyOpkpFy+yHUp:0000000000000000000000000000000004cBK X-Hashcash: 1:20:150227:gregkh@linuxfoundation.org::5k/BkrRE6mvj3pCS:0000000000000000000000000000000000088fv X-Hashcash: 1:20:150227:tal.shorer@gmail.com::sRnhaAjDwetWOotj:00000000000000000000000000000000000000000Gwnr Date: Fri, 27 Feb 2015 13:22:43 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1430 Lines: 36 On Thu, Feb 26 2015, Tal Shorer wrote: > Signed-off-by: Tal Shorer Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/function/f_mass_storage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c > index 811929c..6d5ca2b 100644 > --- a/drivers/usb/gadget/function/f_mass_storage.c > +++ b/drivers/usb/gadget/function/f_mass_storage.c > @@ -1085,7 +1085,7 @@ static int do_inquiry(struct fsg_common *common, struct fsg_buffhd *bh) > if (!curlun) { /* Unsupported LUNs are okay */ > common->bad_lun_okay = 1; > memset(buf, 0, 36); > - buf[0] = 0x7f; /* Unsupported, no device-type */ > + buf[0] = TYPE_NO_LUN; /* Unsupported, no device-type */ > buf[4] = 31; /* Additional length */ > return 36; > } > -- > 2.2.2 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/