Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753893AbbB0MdX (ORCPT ); Fri, 27 Feb 2015 07:33:23 -0500 Received: from osiris.lip6.fr ([132.227.60.30]:57827 "EHLO osiris.lip6.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753343AbbB0MdW (ORCPT ); Fri, 27 Feb 2015 07:33:22 -0500 X-pt: osiris.lip6.fr From: Valentin Rothberg To: akpm@linux-foundation.org, iss_storagedev@hp.com, linux-kernel@vger.kernel.org Cc: Valentin Rothberg Subject: [PATCH] block/cpqarray.c: remove IRQF_DISABLED flag Date: Fri, 27 Feb 2015 13:32:55 +0100 Message-Id: <1425040375-20528-1-git-send-email-Valentin.Rothberg@lip6.fr> X-Mailer: git-send-email 1.9.1 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (osiris.lip6.fr [132.227.60.30]); Fri, 27 Feb 2015 13:33:12 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 33 The IRQF_DISABLED is a NOOP and scheduled to be removed. According to Ingo Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ handlers with interrupts enabled can cause stack overflows when the interrupt line of the issuing device is still active. Signed-off-by: Valentin Rothberg --- drivers/block/cpqarray.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c index 2b94403..9e92b2c 100644 --- a/drivers/block/cpqarray.c +++ b/drivers/block/cpqarray.c @@ -405,8 +405,8 @@ static int cpqarray_register_ctlr(int i, struct pci_dev *pdev) goto Enomem4; } hba[i]->access.set_intr_mask(hba[i], 0); - if (request_irq(hba[i]->intr, do_ida_intr, - IRQF_DISABLED|IRQF_SHARED, hba[i]->devname, hba[i])) + if (request_irq(hba[i]->intr, do_ida_intr, IRQF_SHARED, + hba[i]->devname, hba[i])) { printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n", hba[i]->intr, hba[i]->devname); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/