Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444AbbB0Nie (ORCPT ); Fri, 27 Feb 2015 08:38:34 -0500 Received: from osiris.lip6.fr ([132.227.60.30]:57488 "EHLO osiris.lip6.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753083AbbB0Nid (ORCPT ); Fri, 27 Feb 2015 08:38:33 -0500 X-pt: osiris.lip6.fr From: Valentin Rothberg To: ralf@linux-mips.org, taohl@lemote.com, chenhc@lemote.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, sergei.shtylyov@cogentembedded.com Cc: Valentin Rothberg Subject: [PATCH v2] loongson-3/hpet.c: remove IRQF_DISABLED flag Date: Fri, 27 Feb 2015 14:38:18 +0100 Message-Id: <1425044298-22004-1-git-send-email-Valentin.Rothberg@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1425039262-20003-1-git-send-email-Valentin.Rothberg@lip6.fr> References: <1425039262-20003-1-git-send-email-Valentin.Rothberg@lip6.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (osiris.lip6.fr [132.227.60.30]); Fri, 27 Feb 2015 14:38:25 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 33 The IRQF_DISABLED is a NOOP and scheduled to be removed. According to commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled) running IRQ handlers with interrupts enabled can cause stack overflows when the interrupt line of the issuing device is still active. Signed-off-by: Valentin Rothberg --- v2: Add commit summary of referenced commit. --- arch/mips/loongson/loongson-3/hpet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/loongson/loongson-3/hpet.c b/arch/mips/loongson/loongson-3/hpet.c index e898d68..5c21cd3 100644 --- a/arch/mips/loongson/loongson-3/hpet.c +++ b/arch/mips/loongson/loongson-3/hpet.c @@ -162,7 +162,7 @@ static irqreturn_t hpet_irq_handler(int irq, void *data) static struct irqaction hpet_irq = { .handler = hpet_irq_handler, - .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER, + .flags = IRQF_NOBALANCING | IRQF_TIMER, .name = "hpet", }; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/