Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753328AbbB0Ow1 (ORCPT ); Fri, 27 Feb 2015 09:52:27 -0500 Received: from foss.arm.com ([217.140.101.70]:43555 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbbB0Ow0 (ORCPT ); Fri, 27 Feb 2015 09:52:26 -0500 Date: Fri, 27 Feb 2015 14:52:22 +0000 From: Javi Merino To: Steven Rostedt Cc: "linux-kernel@vger.kernel.org" , Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa , Punit Agrawal Subject: Re: [PATCH v5 3/3] tools lib traceevent: Add support for __print_array() Message-ID: <20150227145221.GD2877@e104805> References: <1422449335-8289-1-git-send-email-javi.merino@arm.com> <1422449335-8289-4-git-send-email-javi.merino@arm.com> <20150227123232.GC2877@e104805> <20150227091505.04fc20ca@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150227091505.04fc20ca@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1934 Lines: 53 On Fri, Feb 27, 2015 at 02:15:05PM +0000, Steven Rostedt wrote: > On Fri, 27 Feb 2015 12:32:32 +0000 > Javi Merino wrote: > > > Hi Steve, > > > > On Wed, Jan 28, 2015 at 12:48:55PM +0000, Javi Merino wrote: > > > Trace can now generate traces with variable element size arrays. Add > > > support to parse them. > > > > > > Cc: Namhyung Kim > > > Cc: Arnaldo Carvalho de Melo > > > Cc: Steven Rostedt > > > Cc: Jiri Olsa > > > Signed-off-by: Javi Merino > > > --- > > > tools/lib/traceevent/event-parse.c | 93 ++++++++++++++++++++++++++++++++++++++ > > > tools/lib/traceevent/event-parse.h | 8 ++++ > > > 2 files changed, 101 insertions(+) > > > > I've seen that patch 1 of this series is now in mainline. What about > > patches 2 and 3 (the updates to tools/lib/traceevent)? Shall I resend > > them? > > Patches 2 and 3 are in tools/lib and need to go through Jiri and > Arnaldo. Please repost them again. I can give them acks. Cool, done. > > These two patches should also be applied to trace-cmd. Do you want me > > to send patches for that to linux-kernel or will you take care of > > applying them there? > > No need, I can pull them from here. I just been a bit busy to do so. No worries. I was just unsure about the process. > > > > Incidentally, why are there two copies of libtraceevent? Shouldn't > > this live only in one place (either kernel or trace-cmd)? > > Actually, libtraceevent does not exist in trace-cmd, just the event > parsing code. Right, that's what I meant. I was wondering about the duplicated code. Thanks, Javi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/