Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752348AbbB0PZL (ORCPT ); Fri, 27 Feb 2015 10:25:11 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:59306 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330AbbB0PZI (ORCPT ); Fri, 27 Feb 2015 10:25:08 -0500 Date: Fri, 27 Feb 2015 09:24:35 -0600 From: Felipe Balbi To: Valentin Rothberg CC: , , , , Subject: Re: [PATCH] usb/isp1760: set IRQ flags properly Message-ID: <20150227152435.GA22183@saruman.tx.rr.com> Reply-To: References: <1425043780-21773-1-git-send-email-Valentin.Rothberg@lip6.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: <1425043780-21773-1-git-send-email-Valentin.Rothberg@lip6.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1844 Lines: 47 --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote: > The IRQF_DISABLED is a NOOP and scheduled to be removed. According to > commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled) > running IRQ handlers with interrupts enabled can cause stack overflows > when the interrupt line of the issuing device is still active. >=20 > This patch removes using this deprecated flag and additionally removes > redundantly setting IRQF_SHARED. why is it redundant ? --=20 balbi --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU8IwzAAoJEIaOsuA1yqREhTwQAJnnGm6z8QWub8eP+5FYpN0X /5YjJL0pgL3Qw8kb54BN1ueM76O75btMNhcMmV0TrcZC6vQeQ/y1koqw9mSI0J2M F+zVfNarxmKZdTZNPoYxr4CQHM7xzGSEZf4cRO67ZtyUVPLzxkkIUHUsxBQbsELj p1rXbAX4e7SAlzZ6reMKfgihDTsV9Fm7bw5rw6n9S6/4XM0ViVlYnLRLuyE/3aic /1gNpUtt6a+MsdyqoOQHAVa2x+kL3QbMAwsMrCAa2cXDhmcy4N/Ru63m859T3Zz/ O9ZZayv4g6ZwiRSrRoagxmqhzIEEIOFPAG71+vynZu/bdPZF37EjKvHw2zWmq0pC HUuysQZ23tk930rQRWRJuTcaH/LKHSFkvu2TLnGIgswAHAiQcd4n4yiWEOS8Un4X sGjXR6iIbkUUgGz6pG+daMVslg1bsPKnQVx+MuBruqVNEcizfkAFeI8uO3PYXhWf qjxRr89wNUJ/mSzmJqqFzInhFLEOnPIUYw44jjyl16O/TUHbYAMgkkEZlaUPRylH fjElujo59a4BmfhuKXXcJ8dFKNTH0RHO5H1yoPu609CLvoXDsCo5oczytRPwPmQE njMT98iWbNqyPO1fFVZS4YT14NkZ0cbM8TRTwQdkKVKnlcdXiFGjWM2AFr47o2aY /BPfLGV98m5Q6JBBSblf =YZ+r -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/