Date: Fri, 27 Feb 2015 10:38:41 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Javi Merino <javi.merino@arm.com>
Cc: acme@redhat.com, jolsa@redhat.com, linux-kernel@vger.kernel.org,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v6 1/2] tools lib traceevent: factor out allocating and
 processing args
Message-ID: <20150227103841.0e9f55d8@gandalf.local.home>
In-Reply-To: <1425048495-10271-2-git-send-email-javi.merino@arm.com>
References: <1425048495-10271-1-git-send-email-javi.merino@arm.com>
	<1425048495-10271-2-git-send-email-javi.merino@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1141
Lines: 47

On Fri, 27 Feb 2015 14:48:14 +0000
Javi Merino <javi.merino@arm.com> wrote:

  
> +static int alloc_and_process_arg(struct event_format *event, char *next_token,
> +				 struct print_arg **print_arg)
> +{
> +	struct print_arg *field;
> +	enum event_type type;
> +	char *token;
> +	int ret = 0;
> +
> +	field = alloc_arg();
> +	if (!field) {
> +		do_warning_event(event, "%s: not enough memory!", __func__);
> +		errno = ENOMEM;
> +		return -1;
> +	}
> +
> +	type = process_arg(event, field, &token);
> +
> +	if (test_type_token(type, token, EVENT_DELIM, next_token)) {

I wonder if we should call this "alloc_and_process_delim()", as this
isn't a generic arg, but only used for deliminators.

-- Steve

> +		errno = EINVAL;
> +		ret = -1;
> +		free_arg(field);
> +		goto out_free_token;
> +	}
> +
> +	*print_arg = field;
> +
> +out_free_token:
> +	free_token(token);
> +
> +	return ret;
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/