MIME-Version: 1.0
In-Reply-To: <20150227152435.GA22183@saruman.tx.rr.com>
References: <1425043780-21773-1-git-send-email-Valentin.Rothberg@lip6.fr> <20150227152435.GA22183@saruman.tx.rr.com>
From: Valentin Rothberg <valentinrothberg@gmail.com>
Date: Fri, 27 Feb 2015 16:48:39 +0100
Message-ID: <CAD3Xx4KXb00NhKDHg23vw17GSqSJPWe1ehK-y+6MH1Nyr82WHg@mail.gmail.com>
Subject: Re: [PATCH] usb/isp1760: set IRQ flags properly
To: balbi@ti.com
Cc: Greg KH <gregkh@linuxfoundation.org>, laurent.pinchart@ideasonboard.com,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1135
Lines: 27

On Fri, Feb 27, 2015 at 4:24 PM, Felipe Balbi <balbi@ti.com> wrote:
> On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote:
>> The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to
>> commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
>> running IRQ handlers with interrupts enabled can cause stack overflows
>> when the interrupt line of the issuing device is still active.
>>
>> This patch removes using this deprecated flag and additionally removes
>> redundantly setting IRQF_SHARED.
>
> why is it redundant ?

It's redundant in the call of isp1760_udc_register() as this function
sets the flag by requesting the IRQ.  I mistakenly removed it also in
the call of isp1760_hcd_register() which does not alter the passed
irqflags.  I will fix this in a second version of this patch.  I am
sorry for this mistake.

 Valentin

> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/