Date: Fri, 27 Feb 2015 09:51:17 -0600
From: Felipe Balbi <balbi@ti.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
CC: <balbi@ti.com>, Greg KH <gregkh@linuxfoundation.org>,
        <laurent.pinchart@ideasonboard.com>, <linux-kernel@vger.kernel.org>,
        <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb/isp1760: set IRQ flags properly
Message-ID: <20150227155117.GE22183@saruman.tx.rr.com>
Reply-To: <balbi@ti.com>
References: <1425043780-21773-1-git-send-email-Valentin.Rothberg@lip6.fr>
 <20150227152435.GA22183@saruman.tx.rr.com>
 <CAD3Xx4KXb00NhKDHg23vw17GSqSJPWe1ehK-y+6MH1Nyr82WHg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="7LkOrbQMr4cezO2T"
Content-Disposition: inline
In-Reply-To: <CAD3Xx4KXb00NhKDHg23vw17GSqSJPWe1ehK-y+6MH1Nyr82WHg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2353
Lines: 57

--7LkOrbQMr4cezO2T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 27, 2015 at 04:48:39PM +0100, Valentin Rothberg wrote:
> On Fri, Feb 27, 2015 at 4:24 PM, Felipe Balbi <balbi@ti.com> wrote:
> > On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote:
> >> The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to
> >> commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
> >> running IRQ handlers with interrupts enabled can cause stack overflows
> >> when the interrupt line of the issuing device is still active.
> >>
> >> This patch removes using this deprecated flag and additionally removes
> >> redundantly setting IRQF_SHARED.
> >
> > why is it redundant ?
>=20
> It's redundant in the call of isp1760_udc_register() as this function
> sets the flag by requesting the IRQ.  I mistakenly removed it also in
> the call of isp1760_hcd_register() which does not alter the passed
> irqflags.  I will fix this in a second version of this patch.  I am
> sorry for this mistake.

no problem, s**t happens ;)

--=20
balbi

--7LkOrbQMr4cezO2T
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJU8JJ1AAoJEIaOsuA1yqREU7UP/2qG52dCfq12HR3ojXjkahkB
54ybHnqP0cCKjfUqDaUGqa7eevhfmtU3CeRY4H7V6t2G5k263xupQn1On7JEaiR2
tGNOx6gYpttUxeFWvkmpwVD8n0yqbPttTE9Sa8FZ1+BXBHKoyGqmKThmyOMsg9kA
wJK4YFyXZ2NhYCQ2vkiixgR0ShBCyame+JodSb/4y3gcTDE1IdqlFIlWwRcP+vT9
cmERqmUBLwr0Zvcrblt6lE9qul1oLHIsqG6XMKCEgO+mP0hGvYnjmqrBpJrCOVpc
7KUR4Z5EiLW+UOMIAil/WsWldUrDTeW2wpepfYIxXCjw1mQThWRfvw+a8fGpS3cb
YvAxIgC5QDbjkvOOvBc5tqiFe9ptp5UXttAxFx0/cU+a4w/v6BHkMoZ6ssKHFqfa
4Lk8ONQJuBv5PagnIeo7/vwZKyUWfoknwFhXUcgxCX2ULWIaBU5cnI565uXECQQf
YyHESCue73aoAN6WzCOM3R6mRdr3PA9xgBZrywSSNbPXpR6r+mnVGoLUXL5MX0ab
o/LEx/IW8pVEBUTdZg0BF6XAPa0I7LtoDW81oHQl9Jyvr2FjxId/mzqtKlJOcHtW
uEfu2S7oXwrbx4UCVYYgsoy4X0AVX+1k7NIvcsXx3Q//3AZ8WGFufIiqnN/0u3b1
IbnqBc6iumjam8Rwblze
=eftz
-----END PGP SIGNATURE-----

--7LkOrbQMr4cezO2T--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/