Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932092AbbB0Q6P (ORCPT ); Fri, 27 Feb 2015 11:58:15 -0500 Received: from pmta2.delivery6.ore.mailhop.org ([54.200.129.228]:56156 "EHLO pmta2.delivery6.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbbB0Q6M (ORCPT ); Fri, 27 Feb 2015 11:58:12 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX180E0fUMJZhFXrIas8dWe7m Date: Fri, 27 Feb 2015 08:29:22 -0800 From: Tony Lindgren To: Murali Karicheri Cc: davem@davemloft.net, mugunthanvnm@ti.com, george.cherian@ti.com, prabhakar.csengg@gmail.com, varkabhadram@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, grygorii.strashko@ti.com, lokeshvutla@ti.com, mpa@pengutronix.de, w-kwok2@ti.com Subject: Re: [PATCH net-next 2/2] net: netcp: select davinci_mdio driver by default Message-ID: <20150227162921.GX11056@atomide.com> References: <1424813251-31610-1-git-send-email-m-karicheri2@ti.com> <1424813251-31610-2-git-send-email-m-karicheri2@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424813251-31610-2-git-send-email-m-karicheri2@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1250 Lines: 36 * Murali Karicheri [150224 13:31]: > Keystone netcp driver re-uses davinci mdio driver. So enable it > by default for keystone netcp driver. > > Signed-off-by: Murali Karicheri > --- > drivers/net/ethernet/ti/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig > index 3bc992c..945a221 100644 > --- a/drivers/net/ethernet/ti/Kconfig > +++ b/drivers/net/ethernet/ti/Kconfig > @@ -88,6 +88,7 @@ config TI_CPTS > config TI_KEYSTONE_NETCP > tristate "TI Keystone NETCP Core Support" > select TI_CPSW_ALE > + select TI_DAVINCI_MDIO > depends on OF > depends on KEYSTONE_NAVIGATOR_DMA && KEYSTONE_NAVIGATOR_QMSS > ---help--- These options should be silent Kconfig options if we're selecting them. Or else you should use depends on instead. In general using select for driver modules will eventually lead into randconfig build failures as things change. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/