Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754849AbbB0Qbu (ORCPT ); Fri, 27 Feb 2015 11:31:50 -0500 Received: from mail.kernel.org ([198.145.29.136]:48860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386AbbB0Qbs (ORCPT ); Fri, 27 Feb 2015 11:31:48 -0500 Date: Fri, 27 Feb 2015 13:31:43 -0300 From: Arnaldo Carvalho de Melo To: He Kuang Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, wangnan0@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf report: Fix branch stack mode cannot be set Message-ID: <20150227163143.GN13373@kernel.org> References: <1423967617-28879-1-git-send-email-hekuang@huawei.com> <54F03FD4.9030200@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54F03FD4.9030200@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2584 Lines: 57 Em Fri, Feb 27, 2015 at 05:58:44PM +0800, He Kuang escreveu: > ping.. Thanks, applied to perf/core. - Arnaldo > 在 2015/2/15 10:33, He Kuang 写道: > >When perf.data file be abtained by using 'perf record -b', perf report > >should use branch stack mode to generate output. But this function is > >broken by improper comparison between boolean and constant -1. > > > >before this patch: > >$perf report -b -i perf.data > >Samples: 16 of event 'cycles', Event count (approx.): 3171896 > >Overhead Command Shared Object Symbol > > 13.59% ls [kernel.kallsyms] [k] prio_tree_remove > > 13.16% ls [kernel.kallsyms] [k] change_pte_range > > 12.09% ls [kernel.kallsyms] [k] page_fault > > 12.02% ls [kernel.kallsyms] [k] zap_pte_range > >... > > > >after this patch: > >$perf report -b -i perf.data > >Samples: 256 of event 'cycles', Event count (approx.): 256 > >Overhead Command Source Shared Object Source Symbol Target Shared Object Target Symbol > > 9.38% ls [unknown] [k] 0000000000000000 [unknown] [k] 0000000000000000 > > 6.25% ls libc-2.19.so [.] _dl_addr libc-2.19.so [.] _dl_addr > > 6.25% ls [kernel.kallsyms] [k] zap_pte_range [kernel.kallsyms] [k] zap_pte_range > > 6.25% ls [kernel.kallsyms] [k] change_pte_range [kernel.kallsyms] [k] change_pte_range > > 0.39% ls [kernel.kallsyms] [k] prio_tree_remove [kernel.kallsyms] [k] prio_tree_remove > >... > > > >Signed-off-by: He Kuang > >--- > > tools/perf/builtin-report.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > >index 2f91094..ecc453b 100644 > >--- a/tools/perf/builtin-report.c > >+++ b/tools/perf/builtin-report.c > >@@ -766,7 +766,7 @@ repeat: > > * 0/1 means the user chose a mode. > > */ > > if (((branch_mode == -1 && has_br_stack) || branch_mode == 1) && > >- branch_call_mode == -1) { > >+ !branch_call_mode) { > > sort__mode = SORT_MODE__BRANCH; > > symbol_conf.cumulate_callchain = false; > > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/