Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755217AbbB0UMz (ORCPT ); Fri, 27 Feb 2015 15:12:55 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:58285 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848AbbB0UMy (ORCPT ); Fri, 27 Feb 2015 15:12:54 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Tony Lindgren , Aaro Koskinen , ivo.g.dimitrov.75@gmail.com, khilman@kernel.org, sre@debian.org, kernel list , sre@ring0.de, Sakari Ailus , Pavel Machek , pali.rohar@gmail.com, linux-omap@vger.kernel.org, patrikbachan@gmail.com Subject: [PATCH] usb: musb: fix Kconfig regression Date: Fri, 27 Feb 2015 21:12:45 +0100 Message-ID: <7445620.7S2XydQea5@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150227153809.GS11056@atomide.com> References: <20150217185518.GA3825@amd> <20150226230307.GA27809@fuloong-minipc.musicnaut.iki.fi> <20150227153809.GS11056@atomide.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ylCbuBqm/jDJqMFE09RsO0CBKUurVOcnaCSE373AnOXcby2puiS YMDb/k4PYbWMINtUIDeN9vXM+8A5VUNjWXUuj5jcY09hRVaC87Ba9DqPtSSOarDKjSbpCQJ Kerhf7cFZCfKlXZCFer0azY/hjVb3Kk+93eJKncIsHGKjTmxh6ZXt8zWh7yH+jFc/Qfdbmh IzDsIkzUmQW++bRiecRUw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1504 Lines: 38 A recent bug fix I did that was marked for stable backports introduced a slightly wrong dependency on CONFIG_OMAP_CONTROL_PHY. I was missing the fact that the PHY driver already stubs out the omap_control_usb_set_mode, and we only need to add a dependency to prevent the musb-omap2430 driver from being built-in when the phy driver is a loadable module, but we should not prevent it from being built altogether when the phy driver is disabled. This changes the dependency to allow OMAP_CONTROL_PHY to be disabled, but to disallow USB_MUSB_OMAP2PLUS from being built-in if OMAP_CONTROL_PHY is a loadable module. Signed-off-by: Arnd Bergmann Fixes: ca784be36cc725 ("usb: start using the control module driver") Cc: # v3.9+ Cc: Felipe Balbi diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index 14e1628483d9..39db8b603627 100644 --- a/drivers/usb/musb/Kconfig +++ b/drivers/usb/musb/Kconfig @@ -79,7 +79,8 @@ config USB_MUSB_TUSB6010 config USB_MUSB_OMAP2PLUS tristate "OMAP2430 and onwards" - depends on ARCH_OMAP2PLUS && USB && OMAP_CONTROL_PHY + depends on ARCH_OMAP2PLUS && USB + depends on OMAP_CONTROL_PHY || !OMAP_CONTROL_PHY select GENERIC_PHY config USB_MUSB_AM35X -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/