Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508AbbB0VYp (ORCPT ); Fri, 27 Feb 2015 16:24:45 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47784 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755344AbbB0VYo (ORCPT ); Fri, 27 Feb 2015 16:24:44 -0500 Date: Fri, 27 Feb 2015 13:24:43 -0800 From: Andrew Morton To: Danesh Petigara Cc: , , , , , , , , Subject: Re: [PATCH v2] mm: cma: fix CMA aligned offset calculation Message-Id: <20150227132443.e17d574d45451f10f413f065@linux-foundation.org> In-Reply-To: <1424821185-16956-1-git-send-email-dpetigara@broadcom.com> References: <1424821185-16956-1-git-send-email-dpetigara@broadcom.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 813 Lines: 22 On Tue, 24 Feb 2015 15:39:45 -0800 Danesh Petigara wrote: > The CMA aligned offset calculation is incorrect for > non-zero order_per_bit values. > > For example, if cma->order_per_bit=1, cma->base_pfn= > 0x2f800000 and align_order=12, the function returns > a value of 0x17c00 instead of 0x400. > > This patch fixes the CMA aligned offset calculation. When fixing a bug please always describe the end-user visible effects of that bug. Without that information others are unable to understand why you are recommending a -stable backport. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/