MIME-Version: 1.0
In-Reply-To: <20150227151707.3bf64000@lwn.net>
References: <1425038116-19227-1-git-send-email-Valentin.Rothberg@lip6.fr> <20150227151707.3bf64000@lwn.net>
From: Valentin Rothberg <valentinrothberg@gmail.com>
Date: Fri, 27 Feb 2015 23:22:36 +0100
Message-ID: <CAD3Xx4+VKhGd=zXdMU2hUEDLdzdW6nunDdrHh6eUQu3ZcA0qwg@mail.gmail.com>
Subject: Re: [PATCH v2] MSI-HOWTO.txt: remove reference on IRQF_DISABLED
To: Jonathan Corbet <corbet@lwn.net>
Cc: bhelgaas@google.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1174
Lines: 30

On Fri, Feb 27, 2015 at 11:17 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> On Fri, 27 Feb 2015 12:55:16 +0100
> Valentin Rothberg <Valentin.Rothberg@lip6.fr> wrote:
>
>> The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to
>> Ingo Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ
>> handlers with interrupts enabled can cause stack overflows when the
>> interrupt line of the issuing device is still active.
>>
>> This patch removes IRQF_DISABLED from this documentation.  It was
>> mentioned to be a solution to avoid deadlocks when a device uses
>> multiple interrupts.  As the flag is a NOOP this solution does not work
>> anymore.
>
> Seems good, applied to the docs tree.  I reworked the commit ID in the
> changelog into the standard form (adding the one-line description),
> though.

Thank you.  I will take care to add the one-line description in the future.

 Valentin

> Thanks,
>
> jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/