Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932392AbbB0W4V (ORCPT ); Fri, 27 Feb 2015 17:56:21 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:52094 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754956AbbB0W4U (ORCPT ); Fri, 27 Feb 2015 17:56:20 -0500 Date: Fri, 27 Feb 2015 23:56:14 +0100 From: Pavel Machek To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Tony Lindgren , Aaro Koskinen , ivo.g.dimitrov.75@gmail.com, khilman@kernel.org, sre@debian.org, kernel list , sre@ring0.de, Sakari Ailus , pali.rohar@gmail.com, linux-omap@vger.kernel.org, patrikbachan@gmail.com Subject: Re: [PATCH] usb: musb: fix Kconfig regression Message-ID: <20150227225614.GC17650@amd> References: <20150217185518.GA3825@amd> <20150226230307.GA27809@fuloong-minipc.musicnaut.iki.fi> <20150227153809.GS11056@atomide.com> <7445620.7S2XydQea5@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7445620.7S2XydQea5@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1301 Lines: 29 On Fri 2015-02-27 21:12:45, Arnd Bergmann wrote: > A recent bug fix I did that was marked for stable backports > introduced a slightly wrong dependency on CONFIG_OMAP_CONTROL_PHY. > > I was missing the fact that the PHY driver already stubs out the > omap_control_usb_set_mode, and we only need to add a dependency > to prevent the musb-omap2430 driver from being built-in when > the phy driver is a loadable module, but we should not prevent it > from being built altogether when the phy driver is disabled. > > This changes the dependency to allow OMAP_CONTROL_PHY to > be disabled, but to disallow USB_MUSB_OMAP2PLUS from being > built-in if OMAP_CONTROL_PHY is a loadable module. > > Signed-off-by: Arnd Bergmann > Fixes: ca784be36cc725 ("usb: start using the control module driver") > Cc: # v3.9+ > Cc: Felipe Balbi Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/