Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751460AbbB1AHb (ORCPT ); Fri, 27 Feb 2015 19:07:31 -0500 Received: from ozlabs.org ([103.22.144.67]:47616 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbbB1AHa (ORCPT ); Fri, 27 Feb 2015 19:07:30 -0500 From: Rusty Russell To: Andrey Ryabinin , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Ryabinin , Dmitry Vyukov Subject: Re: [PATCH 2/2] kasan, module: move MODULE_ALIGN macro into In-Reply-To: <1425049816-11385-2-git-send-email-a.ryabinin@samsung.com> References: <1425049816-11385-1-git-send-email-a.ryabinin@samsung.com> <1425049816-11385-2-git-send-email-a.ryabinin@samsung.com> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 28 Feb 2015 09:31:40 +1030 Message-ID: <87bnkfklgr.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2129 Lines: 63 Andrey Ryabinin writes: > include/linux/moduleloader.h is more suitable place for this macro. > Also change alignment to PAGE_SIZE for CONFIG_KASAN=n as such > alignment already assumed in several places. > > Signed-off-by: Andrey Ryabinin > Cc: Dmitry Vyukov > Cc: Rusty Russell Acked-by: Rusty Russell Thanks, Rusty. > --- > include/linux/kasan.h | 4 ---- > include/linux/moduleloader.h | 8 ++++++++ > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 5fa48a2..5bb0744 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -50,15 +50,11 @@ void kasan_krealloc(const void *object, size_t new_size); > void kasan_slab_alloc(struct kmem_cache *s, void *object); > void kasan_slab_free(struct kmem_cache *s, void *object); > > -#define MODULE_ALIGN (PAGE_SIZE << KASAN_SHADOW_SCALE_SHIFT) > - > int kasan_module_alloc(void *addr, size_t size); > void kasan_free_shadow(const struct vm_struct *vm); > > #else /* CONFIG_KASAN */ > > -#define MODULE_ALIGN 1 > - > static inline void kasan_unpoison_shadow(const void *address, size_t size) {} > > static inline void kasan_enable_current(void) {} > diff --git a/include/linux/moduleloader.h b/include/linux/moduleloader.h > index f755626..4d0cb9b 100644 > --- a/include/linux/moduleloader.h > +++ b/include/linux/moduleloader.h > @@ -84,4 +84,12 @@ void module_arch_cleanup(struct module *mod); > > /* Any cleanup before freeing mod->module_init */ > void module_arch_freeing_init(struct module *mod); > + > +#ifdef CONFIG_KASAN > +#include > +#define MODULE_ALIGN (PAGE_SIZE << KASAN_SHADOW_SCALE_SHIFT) > +#else > +#define MODULE_ALIGN PAGE_SIZE > +#endif > + > #endif > -- > 2.3.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/