Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755673AbbB0XUK (ORCPT ); Fri, 27 Feb 2015 18:20:10 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:64607 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755361AbbB0XUI (ORCPT ); Fri, 27 Feb 2015 18:20:08 -0500 From: Arnd Bergmann To: linux-usb@vger.kernel.org, Felipe Balbi Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , Aaro Koskinen , ivo.g.dimitrov.75@gmail.com, khilman@kernel.org, sre@debian.org, kernel list , sre@ring0.de, Sakari Ailus , Pavel Machek , pali.rohar@gmail.com, linux-omap@vger.kernel.org, patrikbachan@gmail.com Subject: [PATCH, RESEND] usb: musb: fix Kconfig regression Date: Sat, 28 Feb 2015 00:19:41 +0100 Message-ID: <2671702.mSdaGStNT3@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:OPCG5mXTB8vJlu+xMYH5Wtoik6F/LvKydYn+GSwJVEYEoYAmSBZ nN+Pi9N1z+CIELwv+3KbW6pyElzepbJomp8F+mpE8f+JyMy1zjPU07JBBLILrrNwFv8jCCs 3CpcOb8BAB6/doM4BQ1w0Tz7l2l7SvcZLUH1btE0dnHsDpfWSz4vOwcNi3ljrvATNLzg71K slXEJnFgUB+oOAgJFWOxg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1437 Lines: 37 A recent bug fix I did that was marked for stable backports introduced a slightly wrong dependency on CONFIG_OMAP_CONTROL_PHY. I was missing the fact that the PHY driver already stubs out the omap_control_usb_set_mode, and we only need to add a dependency to prevent the musb-omap2430 driver from being built-in when the phy driver is a loadable module, but we should not prevent it from being built altogether when the phy driver is disabled. Signed-off-by: Arnd Bergmann Fixes: ca784be36cc725 ("usb: start using the control module driver") Acked-by: Acked-by: Pavel Machek Cc: # v3.9+ --- Same patch as first time, now with correct recipient and with Pavel's Ack added. diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index 14e1628483d9..39db8b603627 100644 --- a/drivers/usb/musb/Kconfig +++ b/drivers/usb/musb/Kconfig @@ -79,7 +79,8 @@ config USB_MUSB_TUSB6010 config USB_MUSB_OMAP2PLUS tristate "OMAP2430 and onwards" - depends on ARCH_OMAP2PLUS && USB && OMAP_CONTROL_PHY + depends on ARCH_OMAP2PLUS && USB + depends on OMAP_CONTROL_PHY || !OMAP_CONTROL_PHY select GENERIC_PHY config USB_MUSB_AM35X -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/