Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755597AbbB0XvP (ORCPT ); Fri, 27 Feb 2015 18:51:15 -0500 Received: from filtteri6.pp.htv.fi ([213.243.153.189]:51282 "EHLO filtteri6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755341AbbB0XvM (ORCPT ); Fri, 27 Feb 2015 18:51:12 -0500 Date: Sat, 28 Feb 2015 01:51:03 +0200 From: Aaro Koskinen To: Arnd Bergmann Cc: linux-usb@vger.kernel.org, Felipe Balbi , gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , ivo.g.dimitrov.75@gmail.com, khilman@kernel.org, sre@debian.org, kernel list , sre@ring0.de, Sakari Ailus , Pavel Machek , pali.rohar@gmail.com, linux-omap@vger.kernel.org, patrikbachan@gmail.com Subject: Re: [PATCH, RESEND] usb: musb: fix Kconfig regression Message-ID: <20150227235103.GB590@fuloong-minipc.musicnaut.iki.fi> References: <2671702.mSdaGStNT3@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2671702.mSdaGStNT3@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1179 Lines: 30 Hi, On Sat, Feb 28, 2015 at 12:19:41AM +0100, Arnd Bergmann wrote: > A recent bug fix I did that was marked for stable backports > introduced a slightly wrong dependency on CONFIG_OMAP_CONTROL_PHY. > > I was missing the fact that the PHY driver already stubs out the > omap_control_usb_set_mode, and we only need to add a dependency > to prevent the musb-omap2430 driver from being built-in when > the phy driver is a loadable module, but we should not prevent it > from being built altogether when the phy driver is disabled. > > Signed-off-by: Arnd Bergmann > Fixes: ca784be36cc725 ("usb: start using the control module driver") > Acked-by: Acked-by: Pavel Machek > Cc: # v3.9+ This patch allows me to disable redundant CONFIG_OMAP_CONTROL_PHY from 4.0-rc1 .config and still get a working USB on Nokia N9. So: Tested-by: Aaro Koskinen Thanks, A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/