Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751405AbbB1Bqt (ORCPT ); Fri, 27 Feb 2015 20:46:49 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36284 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbbB1Bqs (ORCPT ); Fri, 27 Feb 2015 20:46:48 -0500 Date: Sat, 28 Feb 2015 01:46:42 +0000 From: Mel Gorman To: Huang Ying Cc: LKML , LKP ML Subject: Re: [LKP] [mm] 3484b2de949: -46.2% aim7.jobs-per-min Message-ID: <20150228014642.GG3087@suse.de> References: <1425021696.10337.55.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1425021696.10337.55.camel@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 24 On Fri, Feb 27, 2015 at 03:21:36PM +0800, Huang Ying wrote: > FYI, we noticed the below changes on > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > commit 3484b2de9499df23c4604a513b36f96326ae81ad ("mm: rearrange zone fields into read-only, page alloc, statistics and page reclaim lines") > > The perf cpu-cycles for spinlock (zone->lock) increased a lot. I suspect there are some cache ping-pong or false sharing. > Are you sure about this result? I ran similar tests here and found that there was a major regression introduced near there but it was commit 05b843012335 ("mm: memcontrol: use root_mem_cgroup res_counter") that cause the problem and it was later reverted. On local tests on a 4-node machine, commit 3484b2de9499df23c4604a513b36f96326ae81ad was within 1% of the previous commit and well within the noise. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/