Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbbB1CLT (ORCPT ); Fri, 27 Feb 2015 21:11:19 -0500 Received: from cnbjrel01.sonyericsson.com ([219.141.167.165]:16713 "EHLO cnbjrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750875AbbB1CLR convert rfc822-to-8bit (ORCPT ); Fri, 27 Feb 2015 21:11:17 -0500 From: "Wang, Yalin" To: "'Michal Hocko'" CC: "'Minchan Kim'" , Andrew Morton , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Rik van Riel , Johannes Weiner , Mel Gorman , Shaohua Li Date: Sat, 28 Feb 2015 10:11:13 +0800 Subject: RE: [RFC] mm: change mm_advise_free to clear page dirty Thread-Topic: [RFC] mm: change mm_advise_free to clear page dirty Thread-Index: AdBS0LioOcY/aZFeTK2BpgqOKrXHswAKlLLw Message-ID: <35FD53F367049845BC99AC72306C23D10458D6173BE0@CNBJMBX05.corpusers.net> References: <1424765897-27377-1-git-send-email-minchan@kernel.org> <20150224154318.GA14939@dhcp22.suse.cz> <20150225000809.GA6468@blaptop> <35FD53F367049845BC99AC72306C23D10458D6173BDC@CNBJMBX05.corpusers.net> <20150227210233.GA29002@dhcp22.suse.cz> In-Reply-To: <20150227210233.GA29002@dhcp22.suse.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2908 Lines: 84 > -----Original Message----- > From: Michal Hocko [mailto:mstsxfx@gmail.com] On Behalf Of Michal Hocko > Sent: Saturday, February 28, 2015 5:03 AM > To: Wang, Yalin > Cc: 'Minchan Kim'; Andrew Morton; linux-kernel@vger.kernel.org; linux- > mm@kvack.org; Rik van Riel; Johannes Weiner; Mel Gorman; Shaohua Li > Subject: Re: [RFC] mm: change mm_advise_free to clear page dirty > > On Fri 27-02-15 11:37:18, Wang, Yalin wrote: > > This patch add ClearPageDirty() to clear AnonPage dirty flag, > > the Anonpage mapcount must be 1, so that this page is only used by > > the current process, not shared by other process like fork(). > > if not clear page dirty for this anon page, the page will never be > > treated as freeable. > > Very well spotted! I haven't noticed that during the review. > > > Signed-off-by: Yalin Wang > > --- > > mm/madvise.c | 15 +++++---------- > > 1 file changed, 5 insertions(+), 10 deletions(-) > > > > diff --git a/mm/madvise.c b/mm/madvise.c > > index 6d0fcb8..257925a 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -297,22 +297,17 @@ static int madvise_free_pte_range(pmd_t *pmd, > unsigned long addr, > > continue; > > > > page = vm_normal_page(vma, addr, ptent); > > - if (!page) > > + if (!page || !PageAnon(page) || !trylock_page(page)) > > continue; > > PageAnon check seems to be redundant because we are not allowing > MADV_FREE on any !anon private mappings AFAIR. I only see this check: /* MADV_FREE works for only anon vma at the moment */ if (vma->vm_file) return -EINVAL; but for file private map, there are also AnonPage sometimes, do we need change to like this: if (vma->vm_flags & VM_SHARED) return -EINVAL; > > > > if (PageSwapCache(page)) { > > - if (!trylock_page(page)) > > + if (!try_to_free_swap(page)) > > continue; > > You need to unlock the page here. Good spot. > > - > > - if (!try_to_free_swap(page)) { > > - unlock_page(page); > > - continue; > > - } > > - > > - ClearPageDirty(page); > > - unlock_page(page); > > } > > > > + if (page_mapcount(page) == 1) > > + ClearPageDirty(page); > > Please add a comment about why we need to ClearPageDirty even > !PageSwapCache. Anon pages are usually not marked dirty AFAIR. The > reason seem to be racing try_to_free_swap which sets the page that way > (although I do not seem to remember why are we doing that in the first > place...) > Use page_mapcount to judge if a page can be clear dirty flag seems Not a very good solution, that is because we don't know how many ptes are share this page, I am thinking if there is some good solution For shared AnonPage. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/