Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751331AbbB1KBF (ORCPT ); Sat, 28 Feb 2015 05:01:05 -0500 Received: from terminus.zytor.com ([198.137.202.10]:45387 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbbB1KBA (ORCPT ); Sat, 28 Feb 2015 05:01:00 -0500 Date: Sat, 28 Feb 2015 02:00:30 -0800 From: tip-bot for Daniel Borkmann Message-ID: Cc: jesse.brandeburg@intel.com, mingo@kernel.org, linux-kernel@vger.kernel.org, arjan@linux.intel.com, daniel@iogearbox.net, ast@plumgrid.com, bruce.w.allan@intel.com, hpa@zytor.com, tglx@linutronix.de, bp@suse.de Reply-To: jesse.brandeburg@intel.com, mingo@kernel.org, linux-kernel@vger.kernel.org, arjan@linux.intel.com, ast@plumgrid.com, daniel@iogearbox.net, bruce.w.allan@intel.com, hpa@zytor.com, tglx@linutronix.de, bp@suse.de In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/mm] x86/mm: Unexport set_memory_ro() and set_memory_rw() Git-Commit-ID: 6bbb614ec478961c7443086bdf7fd6784479c14a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2310 Lines: 61 Commit-ID: 6bbb614ec478961c7443086bdf7fd6784479c14a Gitweb: http://git.kernel.org/tip/6bbb614ec478961c7443086bdf7fd6784479c14a Author: Daniel Borkmann AuthorDate: Fri, 27 Feb 2015 15:55:40 +0100 Committer: Ingo Molnar CommitDate: Sat, 28 Feb 2015 10:41:59 +0100 x86/mm: Unexport set_memory_ro() and set_memory_rw() This effectively unexports set_memory_ro() and set_memory_rw() functions, and thus reverts: a03352d2c1dc ("x86: export set_memory_ro and set_memory_rw"). They have been introduced for debugging purposes in e1000e, but no module user is in mainline kernel (anymore?) and we explicitly do not want modules to use these functions, as they i.e. protect eBPF (interpreted & JIT'ed) images from malicious modifications or bugs. Outside of eBPF scope, I believe also other set_memory_*() functions should be unexported on x86 for modules. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Cc: Arjan van de Ven Cc: Borislav Petkov Cc: Bruce Allan Cc: H. Peter Anvin Cc: Jesse Brandeburg Cc: Thomas Gleixner Cc: davem@davemloft.net Link: http://lkml.kernel.org/r/a064393a0a5d319eebde5c761cfd743132d4f213.1425040940.git.daniel@iogearbox.net Signed-off-by: Ingo Molnar --- arch/x86/mm/pageattr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c index 536ea2f..81e8282 100644 --- a/arch/x86/mm/pageattr.c +++ b/arch/x86/mm/pageattr.c @@ -1654,13 +1654,11 @@ int set_memory_ro(unsigned long addr, int numpages) { return change_page_attr_clear(&addr, numpages, __pgprot(_PAGE_RW), 0); } -EXPORT_SYMBOL_GPL(set_memory_ro); int set_memory_rw(unsigned long addr, int numpages) { return change_page_attr_set(&addr, numpages, __pgprot(_PAGE_RW), 0); } -EXPORT_SYMBOL_GPL(set_memory_rw); int set_memory_np(unsigned long addr, int numpages) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/