Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751896AbbB1MyE (ORCPT ); Sat, 28 Feb 2015 07:54:04 -0500 Received: from mga03.intel.com ([134.134.136.65]:54016 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbbB1MyB (ORCPT ); Sat, 28 Feb 2015 07:54:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,667,1418112000"; d="scan'208";a="673152027" Message-ID: <54F1BA64.3020000@linux.intel.com> Date: Sat, 28 Feb 2015 04:53:56 -0800 From: Arjan van de Ven User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: jesse.brandeburg@intel.com, mingo@kernel.org, linux-kernel@vger.kernel.org, ast@plumgrid.com, daniel@iogearbox.net, bruce.w.allan@intel.com, hpa@zytor.com, tglx@linutronix.de, bp@suse.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/mm] x86/mm: Unexport set_memory_ro() and set_memory_rw() References: In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 33 On 2/28/2015 2:00 AM, tip-bot for Daniel Borkmann wrote: > Commit-ID: 6bbb614ec478961c7443086bdf7fd6784479c14a > Gitweb: http://git.kernel.org/tip/6bbb614ec478961c7443086bdf7fd6784479c14a > Author: Daniel Borkmann > AuthorDate: Fri, 27 Feb 2015 15:55:40 +0100 > Committer: Ingo Molnar > CommitDate: Sat, 28 Feb 2015 10:41:59 +0100 > > x86/mm: Unexport set_memory_ro() and set_memory_rw() > > This effectively unexports set_memory_ro() and set_memory_rw() > functions, and thus reverts: > > a03352d2c1dc ("x86: export set_memory_ro and set_memory_rw"). > > They have been introduced for debugging purposes in e1000e, but > no module user is in mainline kernel (anymore?) and we > explicitly do not want modules to use these functions, as they > i.e. protect eBPF (interpreted & JIT'ed) images from malicious > modifications or bugs. > > Outside of eBPF scope, I believe also other set_memory_*() > functions should be unexported on x86 for modules. > Acked-by: Arjan van de Ven -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/