Message-ID: <54F279E6.90307@gmx.de>
Date: Sun, 01 Mar 2015 03:31:02 +0100
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
CC: linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
        Eric Paris <eparis@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] fanotify: Fix event filtering with FAN_ONDIR set
References: <1425037239-18881-1-git-send-email-suzuki.poulose@arm.com>
In-Reply-To: <1425037239-18881-1-git-send-email-suzuki.poulose@arm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 932
Lines: 31

Hi Suzuki,

On 27.02.2015 12:40, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
> 
> With FAN_ONDIR set, the user can end up getting events, which
> it hasn't marked. This was revealed with fanotify04 testcase
> failure on Linux-4.0-rc1, and is a regression from 3.19, revealed
> with commit (66ba93c0d7fe6: fanotify: don't set FAN_ONDIR implicitly
> on a marks ignored mask).
> 

> 
> Fix this by masking the outgoing events to the user, as we
> already take care of FAN_ONDIR and FAN_EVENT_ON_CHILD.
> 

thank you for fixing this. I tested your solution and it works, so you
can add Tested-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>.

Regards,
Lino


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/