Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753320AbbCADQH (ORCPT ); Sat, 28 Feb 2015 22:16:07 -0500 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:60282 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbbCADQB (ORCPT ); Sat, 28 Feb 2015 22:16:01 -0500 Date: Sat, 28 Feb 2015 19:16:00 -0800 (PST) From: Shrikrishna Khare X-X-Sender: skhare@shri-linux.eng.vmware.com To: Sergei Shtylyov cc: sbhatewara@vmware.com, pv-drivers@vmware.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Amitabha Banerjee Subject: Re: [PATCH net-next] Driver: Vmxnet3: Copy TCP header to mapped frame for IPv6 packets In-Reply-To: <54F24ACC.7020108@cogentembedded.com> Message-ID: References: <1425153509-31582-1-git-send-email-skhare@vmware.com> <54F24ACC.7020108@cogentembedded.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2148 Lines: 69 On Sat, 28 Feb 2015, Sergei Shtylyov wrote: > Hello. > > On 02/28/2015 10:58 PM, Shrikrishna Khare wrote: > > > Allows for packet parsing to be done by the fast path. This performance > > optimization already exists for IPv4. Add similar logic for IPv6. > > > Signed-off-by: Amitabha Banerjee > > Signed-off-by: Shrikrishna Khare > > --- > > drivers/net/vmxnet3/vmxnet3_drv.c | 26 ++++++++++++++++---------- > > drivers/net/vmxnet3/vmxnet3_int.h | 5 +++-- > > 2 files changed, 19 insertions(+), 12 deletions(-) > > > diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c > > b/drivers/net/vmxnet3/vmxnet3_drv.c > > index 294214c..9216e6a 100644 > > --- a/drivers/net/vmxnet3/vmxnet3_drv.c > > +++ b/drivers/net/vmxnet3/vmxnet3_drv.c > [...] > > @@ -831,16 +832,20 @@ vmxnet3_parse_and_copy_hdr(struct sk_buff *skb, struct > > vmxnet3_tx_queue *tq, > > if (ctx->ipv4) { > > const struct iphdr *iph = ip_hdr(skb); > > > > - if (iph->protocol == IPPROTO_TCP) > > - ctx->l4_hdr_size = tcp_hdrlen(skb); > > - else if (iph->protocol == IPPROTO_UDP) > > - ctx->l4_hdr_size = sizeof(struct > > udphdr); > > - else > > - ctx->l4_hdr_size = 0; > > - } else { > > - /* for simplicity, don't copy L4 headers */ > > - ctx->l4_hdr_size = 0; > > + protocol = iph->protocol; > > + } else if (ctx->ipv6) { > > + const struct ipv6hdr *ipv6h = ipv6_hdr(skb); > > + > > + protocol = ipv6h->nexthdr; > > } > > + > > + if (protocol == IPPROTO_TCP) > > + ctx->l4_hdr_size = tcp_hdrlen(skb); > > + else if (protocol == IPPROTO_UDP) > > + ctx->l4_hdr_size = sizeof(struct udphdr); > > + else > > + ctx->l4_hdr_size = 0; > > + > > I think the above is asking to be a 'switch (protocol)' instead. > > WBR, Sergei > > Thanks for the review, Sergei. Would fix it, and resubmit the patch. Thanks, Shri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/