Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbbDAHKr (ORCPT ); Wed, 1 Apr 2015 03:10:47 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:52868 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751459AbbDAHKp (ORCPT ); Wed, 1 Apr 2015 03:10:45 -0400 Message-ID: <551B99E8.9060205@huawei.com> Date: Wed, 1 Apr 2015 15:10:32 +0800 From: Yunlong Song User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: David Ahern , , , , CC: , Subject: Re: [PATCH 2/9] perf sched replay: Increase the MAX_PID value to fix assertion failure problem References: <1427809596-29559-1-git-send-email-yunlong.song@huawei.com> <1427809596-29559-3-git-send-email-yunlong.song@huawei.com> <551AAE74.8060402@gmail.com> In-Reply-To: <551AAE74.8060402@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.74.205] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.551B99F4.0027,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: f72e2d909c862092d42450333eef4dc6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1334 Lines: 41 On 2015/3/31 22:25, David Ahern wrote: > On 3/31/15 7:46 AM, Yunlong Song wrote: >> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c >> index a1893e8..c466104 100644 >> --- a/tools/perf/builtin-sched.c >> +++ b/tools/perf/builtin-sched.c >> @@ -28,7 +28,7 @@ >> #define MAX_CPUS 4096 >> #define COMM_LEN 20 >> #define SYM_LEN 129 >> -#define MAX_PID 65536 >> +#define MAX_PID 1024000 >> >> struct sched_atom; > > # cat /proc/sys/kernel/pid_max > 1048576 > > so your proposed change is still not high enough for what I need. > > It would be best to make it dynamic, not static, with run time reallocations as needed. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > Yes, please see my 3rd and 4th patch in the patch sets, which dynamic allocate the memory in run time. -- Thanks, Yunlong Song -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/