Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbbDAHf4 (ORCPT ); Wed, 1 Apr 2015 03:35:56 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:46038 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbbDAHfz (ORCPT ); Wed, 1 Apr 2015 03:35:55 -0400 Date: Wed, 1 Apr 2015 09:35:55 +0200 From: Peter Zijlstra To: Maninder Singh Cc: Andrew Morton , "linux-kernel@vger.kernel.org" , Yogesh Narayan Gaur , AJEET YADAV , Tejun Heo Subject: Re: Re: msgrcv: use freezable blocking call Message-ID: <20150401073555.GT27490@worktop.programming.kicks-ass.net> References: <1685075594.210481427865525094.JavaMail.weblogic@epmlwas09b> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1685075594.210481427865525094.JavaMail.weblogic@epmlwas09b> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 34 On Wed, Apr 01, 2015 at 05:18:46AM +0000, Maninder Singh wrote: > Hi Andrew, > Thanks for making new patch, Actually there is some problem with our mail editor. > It changes tabs with spaces and corrupts the patch, we are solving the same at our end. > Thats why i am sending you signed -off by only for both patches. Sort it and resend, no real great hurry with these patches, right? > 1. For msgrcv: use freezable blocking call > Signed-off-by: Yogesh Gaur > Signed-off-by: Maninder Singh > Signed-off-by: Manjeet Pawar Did you really pass around that patch through 3 people or did it take all three of you to modify those two lines? Should some of those SoBs be a reviewed-by perhaps? > ----> For Peter's Review comment:- This is what, no why mentioned > > This call was selected to be converted to a freezable call because > it doesn't hold any locks or release any resources when interrupted > that might be needed by another freezing task or a kernel driver > during suspend, and is a common site where idle userspace tasks are > blocked. Please put such things in the Changelog so that we can see you've thought about things. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/