Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752372AbbDAJ0N (ORCPT ); Wed, 1 Apr 2015 05:26:13 -0400 Received: from ozlabs.org ([103.22.144.67]:44817 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbbDAJ0L (ORCPT ); Wed, 1 Apr 2015 05:26:11 -0400 From: Rusty Russell To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 1/6] virtio_balloon: transitional interface In-Reply-To: <20150401094236-mutt-send-email-mst@redhat.com> References: <1427831230-28044-1-git-send-email-mst@redhat.com> <1427831230-28044-2-git-send-email-mst@redhat.com> <87mw2sy0fo.fsf@rustcorp.com.au> <20150401094236-mutt-send-email-mst@redhat.com> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 01 Apr 2015 19:53:14 +1030 Message-ID: <87h9t06w3h.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 674 Lines: 18 "Michael S. Tsirkin" writes: > On Wed, Apr 01, 2015 at 02:17:23PM +1030, Rusty Russell wrote: >> I would leave the device *exactly* as is, ugly structure packing and >> all. > > But why? It's going to be used for years, might as well make it clean? Because the only spec which currently exists says to do that. We do need a new virtio memballoon spec, but it'll look nothing like this anyway. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/