Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752278AbbDAKF2 (ORCPT ); Wed, 1 Apr 2015 06:05:28 -0400 Received: from smtp.citrix.com ([66.165.176.89]:9729 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbbDAKF0 (ORCPT ); Wed, 1 Apr 2015 06:05:26 -0400 X-IronPort-AV: E=Sophos;i="5.11,503,1422921600"; d="scan'208";a="248480044" Message-ID: <551BC2E2.9040007@citrix.com> Date: Wed, 1 Apr 2015 11:05:22 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Bob Liu , Konrad Rzeszutek Wilk CC: , , , , , =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion() References: <1427372161-4964-1-git-send-email-bob.liu@oracle.com> <1427372161-4964-2-git-send-email-bob.liu@oracle.com> <5514269D.6050905@citrix.com> <20150328004459.GA14373@l.oracle.com> <551892EC.6030209@oracle.com> In-Reply-To: <551892EC.6030209@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 38 On 30/03/15 01:03, Bob Liu wrote: > > On 03/28/2015 08:44 AM, Konrad Rzeszutek Wilk wrote: >> On Thu, Mar 26, 2015 at 04:32:45PM +0100, Roger Pau Monn? wrote: >>> El 26/03/15 a les 13.16, Bob Liu ha escrit: >>>> There are several place using gnttab async unmap and wait for >>>> completion, so move the common code to a function >>>> gnttab_unmap_refs_async_wait_completion(). >>>> >>>> Signed-off-by: Bob Liu >>> >>> For the blkback parts: >>> >>> Acked-by: Roger Pau Monn? >>> >>> Although, as David already said, I think we should do better than BUG_ON >>> on error. >> > > This patch only keeps the existing behaviour the same as before. I > prefer to make new patches(based on this one) if want to change the > behaviour. > >> Have an 'stuck deferred pages' list and an timer to occasionally >> flush them out? Something similar to 569ca5b3f94cd0b3295ec5943aa457cf4a4f6a3a >> "xen/gnttab: add deferred freeing logic" ? > > Sounds like a good idea. If it failed the first time I don't see how it would succeed later. No one has actually hit this particular BUG_ON() so I would leave it as is. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/