Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbbDAKSn (ORCPT ); Wed, 1 Apr 2015 06:18:43 -0400 Received: from smtp.citrix.com ([66.165.176.89]:39106 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbbDAKSl (ORCPT ); Wed, 1 Apr 2015 06:18:41 -0400 X-IronPort-AV: E=Sophos;i="5.11,503,1422921600"; d="scan'208";a="248482376" Message-ID: <551BC5FF.2010107@citrix.com> Date: Wed, 1 Apr 2015 11:18:39 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Bob Liu , CC: , , , , Subject: Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion() References: <1427372161-4964-1-git-send-email-bob.liu@oracle.com> <1427372161-4964-2-git-send-email-bob.liu@oracle.com> In-Reply-To: <1427372161-4964-2-git-send-email-bob.liu@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 717 Lines: 21 On 26/03/15 12:16, Bob Liu wrote: > There are several place using gnttab async unmap and wait for > completion, so move the common code to a function > gnttab_unmap_refs_async_wait_completion(). > [...] > + > +int gnttab_unmap_refs_async_wait_completion(struct gntab_unmap_queue_data* item) This name is a bit wordy. Can you rename it to: gnttab_unmap_refs_sync() gnttab_unmap_refs_wait(), or gnttab_unmap_refs_safe(). (I can't decide which is the best name.). David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/