Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753426AbbDAKhK (ORCPT ); Wed, 1 Apr 2015 06:37:10 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:47988 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751358AbbDAKhF (ORCPT ); Wed, 1 Apr 2015 06:37:05 -0400 Date: Wed, 1 Apr 2015 12:36:57 +0200 From: Cornelia Huck To: Steven Rostedt Cc: LKML , Christian Borntraeger , David Hildenbrand , Marcelo Tosatti , Xenia Ragiadakou , Sarah Sharp , Mark Brown Subject: Re: [RFC][PATCH] tracing: Replace '-' with '_' in event system names Message-ID: <20150401123657.29d01802.cornelia.huck@de.ibm.com> In-Reply-To: <20150331231802.23527931@grimm.local.home> References: <20150331231802.23527931@grimm.local.home> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15040110-0009-0000-0000-000003AF0C4E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1744 Lines: 48 On Tue, 31 Mar 2015 23:18:02 -0400 Steven Rostedt wrote: > There's a change I want to make to the tracing infrastructure that may > require TRACE_SYSTEM be a valid variable name. As '-' can not be used > in a variable, and I found only three cases that it is a TRACE_SYSTEM > name, I want to ask those that are responsible if it is OK to change > them? > > The three systems are: > > #define TRACE_SYSTEM kvm-s390 > #define TRACE_SYSTEM xhci-hcd > #define TRACE_SYSTEM intel-sst > > > I want to replace the '-' with '_'. But this will have a user space > visible affect, which is why I'm inquiring with you. If this will break > any scripts or annoy any users that you know of, I'll need to make a > work around (which would not be hard to do). But if I don't need to do > that, I prefer to just use TRACE_SYSTEM as is. > > I'll just do the work around if there is any user space tool that you > know of that will break with this change. > > The effect is that the directories in /sys/kernel/debug/tracing/events/ > will be different. That is, > > /sys/kernel/debug/tracing/events/kvm-s390/ > > will become > > /sys/kernel/debug/tracing/events/kvm_s390/ > > And the same for the other two. Is this a problem? The only direct dependency for kvm-s390 I'm aware of is in perf/tests/parse-events.c, added because parsing an event with '-' in the name was broken. Otherwise, I'm not aware of things that should break, excluding local scripts and so on of course. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/