Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983AbbDAKkU (ORCPT ); Wed, 1 Apr 2015 06:40:20 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:56625 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbbDAKkR (ORCPT ); Wed, 1 Apr 2015 06:40:17 -0400 Message-ID: <551BCB0A.4060107@de.ibm.com> Date: Wed, 01 Apr 2015 12:40:10 +0200 From: Christian Borntraeger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org CC: Cornelia Huck , Pawel Moll , virtio-dev@lists.oasis-open.org, linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org Subject: Re: [virtio-dev] [PATCH v3 3/6] virtio_ccw: support non-legacy balloon devices References: <1427884468-23930-1-git-send-email-mst@redhat.com> <1427884468-23930-4-git-send-email-mst@redhat.com> In-Reply-To: <1427884468-23930-4-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15040110-0029-0000-0000-00000407A98C Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1520 Lines: 48 Am 01.04.2015 um 12:35 schrieb Michael S. Tsirkin: > virtio_device_is_legacy_only is always false now, > drop the test from virtio ccw. Can you add the commit subject of patch2 here as a prereq for this patch? This will hopefully avoid backport issues on distros that want to take this patch but not the other for whatever reasons. this patch is then. Reviewed-by: Christian Borntraeger > Signed-off-by: Michael S. Tsirkin > --- > drivers/s390/kvm/virtio_ccw.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c > index 71d7802..6f1fa17 100644 > --- a/drivers/s390/kvm/virtio_ccw.c > +++ b/drivers/s390/kvm/virtio_ccw.c > @@ -1201,13 +1201,9 @@ static int virtio_ccw_online(struct ccw_device *cdev) > vcdev->vdev.id.vendor = cdev->id.cu_type; > vcdev->vdev.id.device = cdev->id.cu_model; > > - if (virtio_device_is_legacy_only(vcdev->vdev.id)) { > - vcdev->revision = 0; > - } else { > - ret = virtio_ccw_set_transport_rev(vcdev); > - if (ret) > - goto out_free; > - } > + ret = virtio_ccw_set_transport_rev(vcdev); > + if (ret) > + goto out_free; > > ret = register_virtio_device(&vcdev->vdev); > if (ret) { > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/