Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753826AbbDAOYv (ORCPT ); Wed, 1 Apr 2015 10:24:51 -0400 Received: from hofr.at ([212.69.189.236]:60802 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753776AbbDAOYr (ORCPT ); Wed, 1 Apr 2015 10:24:47 -0400 Date: Wed, 1 Apr 2015 16:24:44 +0200 From: Nicholas Mc Guire To: Aaron Sierra Cc: Nicholas Mc Guire , David Woodhouse , Brian Norris , Joe Schultz , Wolfram Sang , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: fsl_ifc_nand: use msecs_to_jiffies for time conversion Message-ID: <20150401142444.GA12125@opentech.at> References: <1426245828-15640-1-git-send-email-hofrat@osadl.org> <1162655988.11370.1427896685060.JavaMail.zimbra@xes-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1162655988.11370.1427896685060.JavaMail.zimbra@xes-inc.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2123 Lines: 59 On Wed, 01 Apr 2015, Aaron Sierra wrote: > ----- Original Message ----- > > From: "Nicholas Mc Guire" > > Sent: Friday, March 13, 2015 6:23:47 AM > > > > This is only an API consolidation and should make things more readable > > it replaces var * HZ / 1000 by msecs_to_jiffies(var) which helps readability > > and also handles all corner-cases properly. > > > > Signed-off-by: Nicholas Mc Guire > > --- > > > > Patch was compile tested with corenet64_smp_defconfig > > (implies CONFIG_MTD_NAND_FSL_IFC=y) > > > > Patch is against 4.0-rc3 (localversion-next is -next-20150313 > > > > drivers/mtd/nand/fsl_ifc_nand.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/nand/fsl_ifc_nand.c > > b/drivers/mtd/nand/fsl_ifc_nand.c > > index 4c05f4f..51394e5 100644 > > --- a/drivers/mtd/nand/fsl_ifc_nand.c > > +++ b/drivers/mtd/nand/fsl_ifc_nand.c > > @@ -317,7 +317,7 @@ static void fsl_ifc_run_command(struct mtd_info *mtd) > > > > /* wait for command complete flag or timeout */ > > wait_event_timeout(ctrl->nand_wait, ctrl->nand_stat, > > - IFC_TIMEOUT_MSECS * HZ/1000); > > + msecs_to_jiffies(IFC_TIMEOUT_MSECS)); > > Nicholas, > Your patch makes me think that this timeout value should be calculated > once during initialization and stored in a new member of > struct fsl_ifc_mtd. That would improve readability AND have some > positive impact on performance. > is it not a bit wasteful to put it into struct fsl_ifc_mtd which is used quite often in here ? #define IFC_TIMEOUT msecs_to_jiffies(500) sould do - its only referenced twice and would achieve what you suggested - initializing it in one location and improved readability wait_event_timeout(ctrl->nand_wait, ctrl->nand_stat, IFC_TIMEOUT); would there be any disadvantage of this solution? thx! hofrat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/