Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753674AbbDAO6T (ORCPT ); Wed, 1 Apr 2015 10:58:19 -0400 Received: from mail.kernel.org ([198.145.29.136]:33990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752407AbbDAO6R (ORCPT ); Wed, 1 Apr 2015 10:58:17 -0400 Date: Wed, 1 Apr 2015 11:58:27 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Wang Nan , jolsa@kernel.org, namhyung@kernel.org, mingo@redhat.com, lizefan@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] perf tools: introduce machine_map_new to merge mmap/mmap2 processing code. Message-ID: <20150401145827.GB4549@kernel.org> References: <1427884395-241111-1-git-send-email-wangnan0@huawei.com> <1427884395-241111-3-git-send-email-wangnan0@huawei.com> <20150401121853.GB10820@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150401121853.GB10820@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1337 Lines: 30 Em Wed, Apr 01, 2015 at 02:18:53PM +0200, Jiri Olsa escreveu: > On Wed, Apr 01, 2015 at 10:33:13AM +0000, Wang Nan wrote: > > Create a machine_map_new() and merge mapping code in > > machine__process_mmap2_event() and machine__process_mmap_event() > > together. This patch is a preparation for following map adjustment > > patches. > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > > +static int machine_map_new(struct machine *machine, u64 start, u64 len, > > + u64 pgoff, u32 pid, u32 d_maj, u32 d_min, u64 ino, > > + u64 ino_gen, u32 prot, u32 flags, char *filename, > > + enum map_type type, struct thread *thread) > the name style for this should be more like 'machine__new_map' > I think Arnaldo will chime in.. ;-) Right, I wonder if this is a function that is about 'maps' or 'machines' mostly, that would say what prefix should be used, if map__ or machine__, still need to review this patchset. Just give a really quick lock, eyebrows raised, even more complexity for the symbol layer, wonder if this can't be simplified... - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/