Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbbDAPIy (ORCPT ); Wed, 1 Apr 2015 11:08:54 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:39399 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753292AbbDAPIx (ORCPT ); Wed, 1 Apr 2015 11:08:53 -0400 Date: Wed, 1 Apr 2015 17:08:48 +0200 From: Ralf Baechle To: Jonas Gorski Cc: Florian Fainelli , Joe Perches , Daniel Walter , Linux-MIPS , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] ar7: replace mac address parsing Message-ID: <20150401150848.GA27199@linux-mips.org> References: <20140624153959.GA19564@google.com> <1403624918.29061.16.camel@joe-AO725> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 603 Lines: 18 On Wed, Apr 01, 2015 at 02:17:16PM +0200, Jonas Gorski wrote: > for (i = 0; i < 6; i++) > dev_addr[i] = (char2hex(mac[i * 3]) << 4) + > char2hex(mac[i * 3 + 1]); > > > So I'm tempted to say it should not cause any issues. But my sample > size is rather small. 4.1 is still long enough out to test ... Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/