Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752804AbbDAPiu (ORCPT ); Wed, 1 Apr 2015 11:38:50 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:60979 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752252AbbDAPip convert rfc822-to-8bit (ORCPT ); Wed, 1 Apr 2015 11:38:45 -0400 Date: Wed, 1 Apr 2015 17:38:36 +0200 From: David Hildenbrand To: Alex =?UTF-8?B?QmVubsOpZQ==?= Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org, jan.kiszka@siemens.com, r65777@freescale.com, bp@suse.de, Gleb Natapov , linux-api@vger.kernel.org (open list:ABI/API), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2 01/10] KVM: add commentary for kvm_debug_exit_arch struct Message-ID: <20150401173836.09f7fde1@thinkpad-w530> In-Reply-To: <1427814488-28467-2-git-send-email-alex.bennee@linaro.org> References: <1427814488-28467-1-git-send-email-alex.bennee@linaro.org> <1427814488-28467-2-git-send-email-alex.bennee@linaro.org> Organization: IBM Deutschland GmbH X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15040115-0009-0000-0000-000003B0DAEF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 52 > Bring into line with the commentary for the other structures and their > KVM_EXIT_* cases. s/commentary/comments/ in the subject and description. Unless you want to add a lengthy discussion :) > > Signed-off-by: Alex Bennée > > --- > > v2 > - add comments for other exit types > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 8055706..5eedf84 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -226,6 +226,7 @@ struct kvm_run { > __u32 count; > __u64 data_offset; /* relative to kvm_run start */ > } io; > + /* KVM_EXIT_DEBUG */ > struct { > struct kvm_debug_exit_arch arch; > } debug; > @@ -274,6 +275,7 @@ struct kvm_run { > __u32 data; > __u8 is_write; > } dcr; > + /* KVM_EXIT_INTERNAL_ERROR */ > struct { > __u32 suberror; > /* Available with KVM_CAP_INTERNAL_ERROR_DATA: */ > @@ -284,6 +286,7 @@ struct kvm_run { > struct { > __u64 gprs[32]; > } osi; > + /* KVM_EXIT_PAPR_HCALL */ > struct { > __u64 nr; > __u64 ret; Looks good to me. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/