Date: Wed, 1 Apr 2015 13:01:40 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/asm/head/64: Use __BOOT_TSS instead of literal 0x20
Message-ID: <20150401130140.67a3c6d2@gandalf.local.home>
In-Reply-To: <1427899858-7165-2-git-send-email-dvlasenk@redhat.com>
References: <1427899858-7165-1-git-send-email-dvlasenk@redhat.com>
	<1427899858-7165-2-git-send-email-dvlasenk@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 945
Lines: 37

On Wed,  1 Apr 2015 16:50:58 +0200
Denys Vlasenko <dvlasenk@redhat.com> wrote:

> No code changes.
> 


> diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S
> index 90c1521..b0c0d16 100644
> --- a/arch/x86/boot/compressed/head_64.S
> +++ b/arch/x86/boot/compressed/head_64.S
> @@ -165,7 +165,7 @@ ENTRY(startup_32)
>  	/* After gdt is loaded */
>  	xorl	%eax, %eax
>  	lldt	%ax
> -	movl    $0x20, %eax
> +	movl    $__BOOT_TSS, %eax

        __BOOT_TSS = (GDT_ENTRY_BOOT_TSS * 8)
GDT_ENTRY_BOOT_TSS = (GDT_ENTRY_BOOT_CS + 2)
 GDT_ENTRY_BOOT_CS = 2

(2 + 2) * 8 = 4 * 8 = 32 = 0x20

Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

>  	ltr	%ax
>  
>  	/*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/