Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752919AbbDARBy (ORCPT ); Wed, 1 Apr 2015 13:01:54 -0400 Received: from exprod5og105.obsmtp.com ([64.18.0.180]:35759 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752838AbbDARBr (ORCPT ); Wed, 1 Apr 2015 13:01:47 -0400 MIME-Version: 1.0 In-Reply-To: <20150401074553.GV1524@lahna.fi.intel.com> References: <1427836680-13008-1-git-send-email-fkan@apm.com> <20150401074553.GV1524@lahna.fi.intel.com> Date: Wed, 1 Apr 2015 10:01:45 -0700 Message-ID: Subject: Re: [PATCH] mailbox: add ACPI support for mailbox framework From: Feng Kan To: Mika Westerberg Cc: patches , Jassi Brar , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1714 Lines: 47 On Wed, Apr 1, 2015 at 12:45 AM, Mika Westerberg wrote: > On Tue, Mar 31, 2015 at 02:18:00PM -0700, Feng Kan wrote: >> This will add support for ACPI parsing of the mboxes attribute >> when booting with ACPI table. The client will have a attribute >> mimic the dts call "mboxes". In the ACPI case, the client will >> mark "mboxes" with the ACPI HID of the mbox it wishes to use. >> >> Name (_DSD, Package () { >> ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), >> Package () { >> Package (2) {"mboxes", "ACPIHID"}, >> } >> }) > > Instead of this, why not match against the DT compatible property? > > Name (_HID, "PRP0001") > > Name (_DSD, Package () { > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > Package () { > Package (2) {"compatible", "your-dt-compatible-string"}, > } > }) I think my description was not clear enough. The _DSD section is not meant to identify the mailbox driver, but used by the acpi node that will request the mailbox channel. The dts version would be as below. mailbox: { } user-mbox: { mboxes: <&mailbox 0> } The mboxes attribute in the user of the mbox has to specify the HID of the mbox in order to retrieve channel pointer. > > This all will be done for you automatically with zero changes in the > code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/