Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753317AbbDATzH (ORCPT ); Wed, 1 Apr 2015 15:55:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50087 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107AbbDATzE convert rfc822-to-8bit (ORCPT ); Wed, 1 Apr 2015 15:55:04 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH 1/7] ARM: dts: qcom: Add PM8841 functions device nodes From: Kumar Gala In-Reply-To: <1427900715-26273-2-git-send-email-ivan.ivanov@linaro.org> Date: Wed, 1 Apr 2015 14:54:59 -0500 Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1427900715-26273-1-git-send-email-ivan.ivanov@linaro.org> <1427900715-26273-2-git-send-email-ivan.ivanov@linaro.org> To: "Ivan T. Ivanov" X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1623 Lines: 54 On Apr 1, 2015, at 10:05 AM, Ivan T. Ivanov wrote: > Add configuration nodes for multi purpose pins and > thermal sensor devices. Thermal sensor will report > PMIC die temperature. > > Signed-off-by: Ivan T. Ivanov > --- > arch/arm/boot/dts/qcom-pm8841.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-pm8841.dtsi b/arch/arm/boot/dts/qcom-pm8841.dtsi > index 73813cc..5c109bd 100644 > --- a/arch/arm/boot/dts/qcom-pm8841.dtsi > +++ b/arch/arm/boot/dts/qcom-pm8841.dtsi > @@ -7,6 +7,20 @@ > reg = <0x4 SPMI_USID>; > #address-cells = <1>; > #size-cells = <0>; > + > + pm8841_mpps: mpps@a000 { > + compatible = "qcom,pm8841-mpp"; > + reg = <0xa000 0x400>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupts = <4 0xa0 0 0>, <4 0xa1 0 0>, <4 0xa2 0 0>, <4 0xa3 0 0>; What?s the interrupt parent here with 4 cells? Can we cleanup the last cell to use proper define for level/edge etc. > + }; > + > + temp-alarm@2400 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0x2400 0x100>; > + interrupts = <4 0x24 0 IRQ_TYPE_EDGE_RISING>; > + }; > }; > > usid5: pm8841@5 { > -- > 1.9.1 > -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/